From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [pull request] Pull request for branch yem/providers
Date: Fri, 20 Dec 2013 10:31:43 +0100 [thread overview]
Message-ID: <20131220103143.53d1434e@skate> (raw)
In-Reply-To: <cover.1387495624.git.yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Fri, 20 Dec 2013 00:43:23 +0100, Yann E. MORIN wrote:
> This series is a third attempt at trying to fix the BR2_EXTERNAL issue,
> in that packages in BR2_EXTERNAL can't be providers of an implementation
> for a virtual package, such as libegl.
I must say I really like this proposal! It both makes virtual packages
better, and solves the BR2_EXTERNAL problem without making invasive
changes in the package infrastructure.
A few minor questions:
*) Shouldn't we use 'qstrip' when doing:
POWERVR_DEPENDENCIES = $(BR2_PACKAGE_PROVIDES_POWERVR)
*) The jpeg virtual package should also be converted in the same way.
*) In PATCH 1, in package/rpi-userland/Config.in, you're adding an if
BR2_PACKAGE_RPI_USERLAND ... endif block, but *before* the comment
related to the toolchain dependencies of rpi-userland. I never
remember if that is the situation causing indentation problem of the
comment in menuconfig or not. Would be good to check this.
Thanks for doing this!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-12-20 9:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 23:43 [Buildroot] [pull request] Pull request for branch yem/providers Yann E. MORIN
2013-12-19 23:43 ` [Buildroot] [PATCH 1/5] package/opengl/libegl: switch to package-defined providers Yann E. MORIN
2013-12-19 23:43 ` [Buildroot] [PATCH 2/5] package/opengl/libgles: " Yann E. MORIN
2013-12-19 23:43 ` [Buildroot] [PATCH 3/5] package/opengl/libopenvg: " Yann E. MORIN
2013-12-19 23:43 ` [Buildroot] [PATCH 4/5] package/opengl/libopenmax: " Yann E. MORIN
2013-12-19 23:43 ` [Buildroot] [PATCH 5/5] package/powervr: " Yann E. MORIN
2013-12-20 9:31 ` Thomas Petazzoni [this message]
2013-12-20 9:43 ` [Buildroot] [pull request] Pull request for branch yem/providers Yann E. MORIN
2013-12-20 9:49 ` Thomas Petazzoni
2013-12-21 17:35 ` Yann E. MORIN
2013-12-20 18:03 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220103143.53d1434e@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.