From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] bluez-utils: Add GATT support
Date: Fri, 20 Dec 2013 10:54:24 +0100 [thread overview]
Message-ID: <20131220105424.19575f8a@skate> (raw)
In-Reply-To: <1387481306-25377-1-git-send-email-alexandre.belloni@free-electrons.com>
Dear Alexandre Belloni,
On Thu, 19 Dec 2013 20:28:26 +0100, Alexandre Belloni wrote:
> +config BR2_PACKAGE_BLUEZ_UTILS_GATT
> + bool "GATT support"
You need to select BR2_PACKAGE_READLINE here.
> + help
> + GATT support
Maybe it would be nice to say a few words about what GATT is here,
since it's not immediately clear what it is.
> endif
>
> comment "bluez-utils needs a toolchain w/ wchar, threads"
> diff --git a/package/bluez_utils/bluez_utils.mk b/package/bluez_utils/bluez_utils.mk
> index 7038638a0748..f6484ae723af 100644
> --- a/package/bluez_utils/bluez_utils.mk
> +++ b/package/bluez_utils/bluez_utils.mk
> @@ -37,6 +37,13 @@ BLUEZ_UTILS_CONF_OPT += \
> --disable-audio
> endif
>
> +ifeq ($(BR2_PACKAGE_BLUEZ_UTILS_GATT),y)
> +BLUEZ_UTILS_DEPENDENCIES += readline
> +BLUEZ_UTILS_CONF_OPT += --enable-gatt
> +else
> +BLUEZ_UTILS_CONF_OPT += --disable-gatt
> +endif
Please use spaces after the += operator, and not tabs.
feq ($(BR2_PACKAGE_BLUEZ_UTILS_GATT),y)
BLUEZ_UTILS_DEPENDENCIES += readline
BLUEZ_UTILS_CONF_OPT += --enable-gatt
else
BLUEZ_UTILS_CONF_OPT += --disable-gatt
endif
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2013-12-20 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 19:28 [Buildroot] [PATCH] bluez-utils: Add GATT support Alexandre Belloni
2013-12-20 9:54 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220105424.19575f8a@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.