From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] qt5: version bump
Date: Fri, 20 Dec 2013 10:57:15 +0100 [thread overview]
Message-ID: <20131220105715.4efa4168@skate> (raw)
In-Reply-To: <87a9fwonur.fsf@dell.be.48ers.dk>
Dear Peter Korsgaard,
On Thu, 19 Dec 2013 16:35:24 +0100, Peter Korsgaard wrote:
> >>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
> > -bump version to 5.2.0
> > -remove unneeded patches
> > -remove invalid configure options
>
> > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> > ---
> > package/qt5/qt5.mk | 4 +-
> > ...-Add-egl-cflags-when-opengles2-is-enabled.patch | 32 ----
> > .../qt5/qt5base/qt5base-0003-uclibc-no-lfs.patch | 36 -----
>
> This patch is still needed.
>
> > package/qt5/qt5base/qt5base-0008-qatomic-ppc.patch | 29 ----
>
> And so is this.
IMO, this is a good reason, for package bumps, to *require* in the
commit log some details about how patches are updated: why some patches
are removed, some others added, and the others updated. By requiring
this, we will really encourage people to think about the patches, and
provide a justification as to why an existing patch is no longer needed.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-12-20 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 13:57 [Buildroot] [PATCH 1/3] qt5webkit: disable for MIPS64 Vicente Olivert Riera
2013-12-17 13:57 ` [Buildroot] [PATCH 2/3] qt5: version bump Vicente Olivert Riera
2013-12-19 15:35 ` Peter Korsgaard
2013-12-20 9:57 ` Thomas Petazzoni [this message]
2013-12-20 10:05 ` Peter Korsgaard
2013-12-17 13:57 ` [Buildroot] [PATCH 3/3] qt5base: Add support for MIPS64 BigEndian Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220105715.4efa4168@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.