From: "Frank Ch. Eigler" <fche@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
linux-arch@vger.kernel.org,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Sandeepa Prabhu <sandeepa.prabhu@linaro.org>,
x86@kernel.org, lkml <linux-kernel@vger.kernel.org>,
"Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
systemtap@sourceware.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH -tip v6 00/22] kprobes: introduce NOKPROBE_SYMBOL(), cleanup and fixes crash bugs
Date: Fri, 20 Dec 2013 08:40:49 -0500 [thread overview]
Message-ID: <20131220134049.GC30373@redhat.com> (raw)
In-Reply-To: <20131220082056.GA15934@gmail.com>
Hi -
mingo wrote:
> [...]
> For example a hash table (hashed by probe address) could be used in
> addition to the list, to speed up basic operations.
In the past, when this sort of behavior popped up, it was due to
machine-wide halt/sync operations being done too eagerly. At one
point, the kprobes-unregistration interface grew a mass-unregister API
to batch them (and save the machine sync's between operations). Maybe
with the new checks/logic, a similar batching API may be needed for
the registration side.
I'll try to get more perf data once the VM comes back up; after a
couple of hours of the test getting started, it died (for possibly
unrelated reasons).
[ 133.073670] stap_bc6054113aa63134d411836da0afefc3_123_1261: module verification failed: signature and/or required key missing - tainting kernel
[ 404.357210] stap_4c53547addc9f25dd87ac4afa0407ed6_36_1948: systemtap: 2.5/0.157, base: ffffffffa0201000, memory: 15882data/24text/1ctx/2058net/4625alloc kb, probes: 34692
[ 1655.745075] hrtimer: interrupt took 1225946 ns
[ 3969.175039] [sched_delayed] sched: RT throttling activated
[10812.665534] kernel tried to execute NX-protected page - exploit attempt? (uid: 0)
[10812.665534] BUG: unable to handle kernel paging request at ffff88007902f038
[10812.665534] IP: [<ffff88007902f038>] 0xffff88007902f038
[10812.665534] PGD 2d90067 PUD 2d93067 PMD 80000000790001e3
[10812.665534] Oops: 0010 [#1] SMP
[10812.665534] Modules linked in: stap_4c53547addc9f25dd87ac4afa0407ed6_36_1948(OF) rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd sunrpc fscache ppdev microcode parport_pc parport i2c_piix4 virtio_balloon i2c_core serio_raw virtio_net virtio_pci ata_generic virtio_ring pata_acpi virtio [last unloaded: stap_89fcd2b984e11a30dd08d141e6b47e13_123_1681]
[10812.665534] CPU: 1 PID: -30720 Comm: <F8><A1><D0>x Tainted: GF O 3.13.0-rc4-01828-g8b349c29efae #1
[10812.665534] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
[10812.665534] BUG: unable to handle kernel paging request at 000000008f896e09
[10812.665534] IP: [<ffffffff810d9f55>] do_raw_spin_trylock+0x5/0x60
[10812.665534] PGD 0
[10812.665534] Thread overran stack, or stack corrupted
[10812.665534] Oops: 0000 [#2] SMP
[10812.665534] Modules linked in: stap_4c53547addc9f25dd87ac4afa0407ed6_36_1948(OF) rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd sunrpc fscache ppdev microcode parport_pc parport i2c_piix4 virtio_balloon i2c_core serio_raw virtio_net virtio_pci ata_generic virtio_ring pata_acpi virtio [last unloaded: stap_89fcd2b984e11a30dd08d141e6b47e13_123_1681]
[10812.665534] CPU: 1 PID: -30720 Comm: <F8><A1><D0>x Tainted: GF O 3.13.0-rc4-01828-g8b349c29efae #1
[10812.665534] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
[10812.665534] BUG: unable to handle kernel paging request at 000000008f896e09
[10812.665534] IP: [<ffffffff810d9f55>] do_raw_spin_trylock+0x5/0x60
[10812.665534] PGD 0
[10812.665534] Thread overran stack, or stack corrupted
[10812.665534] Oops: 0000 [#3] SMP
[10812.665534] Modules linked in: stap_4c53547addc9f25dd87ac4afa0407ed6_36_1948(OF) rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd sunrpc fscache ppdev microcode parport_pc parport i2c_piix4 virtio_balloon i2c_core serio_raw virtio_net virtio_pci ata_generic virtio_ring pata_acpi virtio [last unloaded: stap_89fcd2b984e11a30dd08d141e6b47e13_123_1681]
[10812.665534] CPU: 1 PID: -30720 Comm: <F8><A1><D0>x Tainted: GF O 3.13.0-rc4-01828-g8b349c29efae #1
[10812.665534] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
[10812.665534] BUG: unable to handle kernel paging request at 000000008f896e09
[10812.665534] IP: [<ffffffff810d9f55>] do_raw_spin_trylock+0x5/0x60
[10812.665534] PGD 0
[10812.665534] Thread overran stack, or stack corrupted
[10812.665534] Oops: 0000 [#4] SMP
[10812.665534] Modules linked in: stap_4c53547addc9f25dd87ac4afa0407ed6_36_1948(OF) rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd sunrpc fscache ppdev microcode parport_pc parport i2c_piix4 virtio_balloon i2c_core serio_raw virtio_net virtio_pci ata_generic virtio_ring pata_acpi virtio [last unloaded: stap_89fcd2b984e11a30dd08d141e6b47e13_123_1681]
[10812.665534] CPU: 1 PID: -30720 Comm: <F8><A1><D0>x Tainted: GF O 3.13.0-rc4-01828-g8b349c29efae #1
[10812.665534] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
[10812.665534] BUG: unable to handle kernel paging request at 000000008f896e09
[10812.665534] IP: [<ffffffff810d9f55>] do_raw_spin_trylock+0x5/0x60
[10812.665534] PGD 0
[10812.665534] Thread overran stack, or stack corrupted
[10812.665042] ------------[ cut here ]------------
[10812.665042] WARNING: CPU: 0 PID: 1948 at arch/x86/kernel/kprobes/core.c:600 reenter_kprobe+0x3c/0xd0()
[10812.665042] Modules linked in: stap_4c53547addc9f25dd87ac4afa0407ed6_36_1948(OF) rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd sunrpc fscache ppdev microcode parport_pc parport i2c_piix4 virtio_balloon i2c_core serio_raw virtio_net virtio_pci ata_generic virtio_ring pata_acpi virtio [last unloaded: stap_89fcd2b984e11a30dd08d141e6b47e13_123_1681]
- FChE
next prev parent reply other threads:[~2013-12-20 13:41 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 9:03 [PATCH -tip v6 00/22] kprobes: introduce NOKPROBE_SYMBOL(), cleanup and fixes crash bugs Masami Hiramatsu
2013-12-19 9:03 ` [PATCH -tip v6 01/22] kprobes: Prohibit probing on .entry.text code Masami Hiramatsu
2013-12-19 9:03 ` [PATCH -tip v6 02/22] kprobes: Introduce NOKPROBE_SYMBOL() macro for blacklist Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 03/22] [BUGFIX] kprobes/x86: Prohibit probing on debug_stack_* Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 04/22] [BUGFIX] x86: Prohibit probing on native_set_debugreg/load_idt Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 05/22] [BUGFIX] x86: Prohibit probing on thunk functions and restore Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 06/22] [BUGFIX] x86: Prohibit probing on memcpy/memset Masami Hiramatsu
2013-12-19 9:37 ` Jovi Zhangwei
2013-12-20 2:37 ` Masami Hiramatsu
2013-12-20 3:07 ` Jovi Zhangwei
2013-12-20 4:42 ` Masami Hiramatsu
2013-12-20 8:31 ` Jovi Zhangwei
2013-12-20 9:21 ` Masami Hiramatsu
2013-12-23 4:51 ` Jovi Zhangwei
2013-12-23 10:59 ` Masami Hiramatsu
2013-12-24 6:39 ` Jovi Zhangwei
2013-12-24 8:32 ` Masami Hiramatsu
2013-12-24 9:53 ` Jovi Zhangwei
2013-12-24 15:58 ` Masami Hiramatsu
2013-12-25 14:44 ` Jovi Zhangwei
2013-12-19 9:04 ` [PATCH -tip v6 07/22] kprobes/x86: Call exception handlers directly from do_int3/do_debug Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 08/22] kprobes/x86: Allow probe on some kprobe preparation functions Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 09/22] kprobes: Allow probe on some kprobe functions Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 10/22] ftrace/kprobes: Allow probing on some preparation functions Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 11/22] x86: Allow kprobes on text_poke/hw_breakpoint Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 12/22] x86: Use NOKPROBE_SYMBOL() instead of __kprobes annotation Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 13/22] kprobes: Use NOKPROBE_SYMBOL macro instead of __kprobes Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 14/22] ftrace/kprobes: Use NOKPROBE_SYMBOL macro in ftrace Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 15/22] notifier: Use NOKPROBE_SYMBOL macro in notifier Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 16/22] sched: Use NOKPROBE_SYMBOL macro in sched Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 17/22] kprobes: Show blacklist entries via debugfs Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 18/22] kprobes: Support blacklist functions in module Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 19/22] kprobes: Use NOKPROBE_SYMBOL() in sample modules Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 20/22] kprobes/x86: Use kprobe_blacklist for .kprobes.text and .entry.text Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 21/22] kprobes/x86: Remove unneeded preempt_disable/enable in interrupt handlers Masami Hiramatsu
2013-12-19 9:04 ` [PATCH -tip v6 22/22] [RFC] kprobes/x86: Add emergency recovery process for bad kprobes Masami Hiramatsu
2013-12-19 20:46 ` [PATCH -tip v6 00/22] kprobes: introduce NOKPROBE_SYMBOL(), cleanup and fixes crash bugs Frank Ch. Eigler
2013-12-20 4:21 ` Masami Hiramatsu
2013-12-20 8:20 ` Ingo Molnar
2013-12-20 9:31 ` Masami Hiramatsu
2013-12-20 10:46 ` Ingo Molnar
2013-12-22 21:10 ` Masami Hiramatsu
2013-12-23 13:04 ` Ingo Molnar
2013-12-24 1:19 ` Masami Hiramatsu
2014-01-29 11:22 ` Masami Hiramatsu
2014-02-09 14:37 ` Ingo Molnar
2014-02-09 21:27 ` Frank Ch. Eigler
2014-02-10 4:02 ` Masami Hiramatsu
2014-02-10 11:31 ` Masami Hiramatsu
2013-12-20 13:40 ` Frank Ch. Eigler [this message]
2013-12-22 21:32 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220134049.GC30373@redhat.com \
--to=fche@redhat.com \
--cc=ananth@in.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sandeepa.prabhu@linaro.org \
--cc=systemtap@sourceware.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.