Re: [PATCH V2 1/2] mfd: AS3722: add dt node properties for system power controller

[Lee Jones <lee.jones@linaro.org>]

On Fri, 20 Dec 2013, Laxman Dewangan wrote:

> ams AS3722 device supports the power off by turning off its all rails.
> 
> Add dt node properties to enable this functionality on this device.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Tested-by: Stephen Warren <swarren@nvidia.com>

I'm guessing I can use this as an Ack?

> ---
> Changes form V1:
> - Rephrase sentence and mention that propery is boolean type.
> - Added Tested by.
> 
>  Documentation/devicetree/bindings/mfd/as3722.txt |   11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt
> index fc2191e..8edcb9b 100644
> --- a/Documentation/devicetree/bindings/mfd/as3722.txt
> +++ b/Documentation/devicetree/bindings/mfd/as3722.txt
> @@ -112,6 +112,15 @@ Following are properties of regulator subnode.
>  		ams,enable-tracking: Enable tracking with SD1, only supported
>  			by LDO3.
>  
> +Power-off:
> +=========
> +AS3722 supports the system power off by turning off all its rail. This
> +is provided through pm_power_off.
> +The device node should have the following properties to enable this
> +functionality
> +ams,system-power-controller: Boolean, to enable the power off functionality
> +        through this device.
> +
>  Example:
>  --------
>  #include <dt-bindings/mfd/as3722.h>
> @@ -120,6 +129,8 @@ ams3722 {
>  	compatible = "ams,as3722";
>  	reg = <0x48>;
>  
> +	ams,system-power-controller;
> +
>  	interrupt-parent = <&intc>;
>  	interrupt-controller;
>  	#interrupt-cells = <2>;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog