From: Thierry Reding <thierry.reding@gmail.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/4] drm/dp: Add AUX channel infrastructure
Date: Fri, 20 Dec 2013 15:33:54 +0100 [thread overview]
Message-ID: <20131220143353.GA29708@ulmo.nvidia.com> (raw)
In-Reply-To: <87a9fvk6uy.fsf@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 983 bytes --]
On Fri, Dec 20, 2013 at 03:08:21PM +0200, Jani Nikula wrote:
> On Tue, 17 Dec 2013, Thierry Reding <thierry.reding@gmail.com> wrote:
[...]
> > +/**
> > + * drm_dp_dpcd_writeb() - write a single byte to the DPCD
> > + * @aux: DisplayPort AUX channel
> > + * @offset: address of the register to write
> > + * @valuep: value to write to the register
> > + *
> > + * Returns the number of bytes transferred (1) on success, or a negative
> > + * error code on failure.
> > + */
> > +static inline ssize_t drm_dp_dpcd_writeb(struct drm_dp_aux *aux, u8 value,
> > + unsigned int offset)
>
> I'd much prefer offset before value parameter. Why would you have these
> the other way around here than in all the other functions?
I guess I thought this would mirror the convention seen with readl() and
writel(), but I suppose since drm_dp_dpcd_readb() doesn't actually look
anything like readl() there's no consistency here anyway. I'll change it
around.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2013-12-20 14:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 16:20 [PATCH v2 0/4] drm/dp: Introduce AUX channel infrastructure Thierry Reding
2013-12-17 16:20 ` [PATCH v2 1/4] drm/dp: Add " Thierry Reding
2013-12-17 16:44 ` Jani Nikula
2013-12-20 9:03 ` Thierry Reding
2013-12-20 13:08 ` Jani Nikula
2013-12-20 14:33 ` Thierry Reding [this message]
2013-12-17 16:20 ` [PATCH v2 2/4] drm/dp: Add drm_dp_dpcd_read_link_status() Thierry Reding
2013-12-17 16:20 ` [PATCH v2 3/4] drm/dp: Add DisplayPort link helpers Thierry Reding
2013-12-20 13:22 ` Jani Nikula
2013-12-17 16:20 ` [PATCH v2 4/4] drm/dp: Allow registering AUX channels as I2C busses Thierry Reding
2013-12-17 17:11 ` Jani Nikula
2013-12-20 9:13 ` Thierry Reding
2013-12-18 8:52 ` Daniel Vetter
2013-12-20 9:27 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220143353.GA29708@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.