All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: hannes@stressinduktion.org
Cc: netdev <netdev@vger.kernel.org>, linux-hams@vger.kernel.org
Subject: possible rose recvmsg behavior change after msg_namelen fixes
Date: Fri, 20 Dec 2013 17:02:07 +0100	[thread overview]
Message-ID: <20131220160207.GC29632@breakpoint.cc> (raw)

Hi.

recvmsg handler in net/rose/af_rose.c performs size-check
on  ->msg_namelen:

if (msg->msg_namelen >= sizeof(struct full_sockaddr_rose)) {
 /* something */
} else {
  /* else */
}

Now that msg_namelen is zeroed before the handler calls we always
hit the 'else' branch.

TBH i don't comprehend how this was/is supposed to work.

Could someone who is familiar with AF_ROSE look at this, before
I send untested patch that blindly chops off code?

Thanks!

             reply	other threads:[~2013-12-20 16:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-20 16:02 Florian Westphal [this message]
2013-12-20 18:11 ` possible rose recvmsg behavior change after msg_namelen fixes Hannes Frederic Sowa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131220160207.GC29632@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=hannes@stressinduktion.org \
    --cc=linux-hams@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.