From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gokulnath A <gokul.linux@gmail.com>
Cc: Michael Hoefler <michael.hoefler@studium.uni-erlangen.de>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
linux-kernel@i4.cs.fau.de,
Christoph Kohl <christoph.kohl@t-online.de>,
open list <linux-kernel@vger.kernel.org>,
Rupert Muchembled <rupert@rmuch.net>
Subject: Re: [PATCHv2 1/3] silicom: fix whitespace issues in bypass.c
Date: Fri, 20 Dec 2013 09:01:59 -0800 [thread overview]
Message-ID: <20131220170159.GA15634@kroah.com> (raw)
In-Reply-To: <CADKvho6HF9A6agDXwrg7UPcOS0YQh3bPmGzPjOAEO8tZ8cveTw@mail.gmail.com>
On Fri, Dec 20, 2013 at 08:36:48PM +0530, Gokulnath A wrote:
> Hello Michael,
>
> On Fri, Dec 20, 2013 at 7:21 PM, Michael Hoefler
> <michael.hoefler@studium.uni-erlangen.de> wrote:
> > This patch addresses several problems in bypass.c found by checkpatch.
> > Furthermore it removes/adds some empty lines to make the code more readable.
> >
> > The following problems are fixed:
> > - line over 80 characters
> > - space after logical operator !
> > - spaces instead of tabs
> > - missing empty line after local declarations
> > - empty line after {
> >
>
> Please do one thing per patch, As Greg suggested for me in previous mail
> conversations. Here you could have at least 3 or 4 patches.
> For example, first patch would be a fix for line over 80 characters,
> followed by the other problems as mentioned above by you.
Nah, all of these are affecting the same macros, so it's ok, I'll take
it as-is.
thanks,
greg k-h
next prev parent reply other threads:[~2013-12-20 17:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 13:51 [PATCHv2 0/3] staging: silicom: fix code styling according to checkpatch Michael Hoefler
2013-12-20 13:51 ` [PATCHv2 1/3] silicom: fix whitespace issues in bypass.c Michael Hoefler
2013-12-20 15:06 ` Gokulnath A
2013-12-20 17:01 ` Greg Kroah-Hartman [this message]
2013-12-20 17:05 ` Gokulnath A
2013-12-20 13:51 ` [PATCHv2 2/3] silicom: fix coding style " Michael Hoefler
2013-12-20 13:51 ` [PATCHv2 3/3] silicom: remaining checkpatch " Michael Hoefler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220170159.GA15634@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=christoph.kohl@t-online.de \
--cc=devel@driverdev.osuosl.org \
--cc=gokul.linux@gmail.com \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hoefler@studium.uni-erlangen.de \
--cc=rupert@rmuch.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.