From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756697Ab3LTRfd (ORCPT ); Fri, 20 Dec 2013 12:35:33 -0500 Received: from mga03.intel.com ([143.182.124.21]:33298 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756625Ab3LTRfc (ORCPT ); Fri, 20 Dec 2013 12:35:32 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.95,522,1384329600"; d="scan'208";a="329342523" Date: Fri, 20 Dec 2013 09:40:25 -0800 From: David Cohen To: Ingo Molnar Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] x86: intel-mid: sfi_handle_*_dev() should check for pdata error code Message-ID: <20131220174025.GA5186@psi-dev26.jf.intel.com> References: <1387244246-20714-1-git-send-email-david.a.cohen@linux.intel.com> <1387518179-4316-1-git-send-email-david.a.cohen@linux.intel.com> <1387518179-4316-2-git-send-email-david.a.cohen@linux.intel.com> <20131220084953.GB21133@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131220084953.GB21133@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ingo, On Fri, Dec 20, 2013 at 09:49:53AM +0100, Ingo Molnar wrote: > > * David Cohen wrote: > > > Prevent sfi_handle_*_dev() to register device in case > > intel_mid_sfi_get_pdata() failed to execute. > > > > Since 'NULL' is a valid return value, this patch makes > > sfi_handle_*_dev() functions to use IS_ERR() to validate returned pdata. > > Is this bug triggering in practice? If not then please say so in the > changelog. If yes then is this patch desired for v3.13 merging and Despite the bug exists and the patch is fixing it, it is really unlikely to happen regularly unless the hw has wrong FW. OTOH it is pretty useful during development of platform code to spot and fix errors and typos faster. I don't think there's need to go to 3.13. It can be applied for next version after the patch set I sent it in reply to. > also please fix the changelog to conform to the standard changelog > style: > > - first describe the symptoms of the bug - how does a user notice? > > - then describe how the code behaves today and how that is causing > the bug > > - and then only describe how it's fixed. > > The first item is the most important one - while developers > (naturally) tend to concentrate on the least important point, the last > one. I'll amend the description. Br, David > > Thanks, > > Ingo