From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: net: vmxnet3 calls skb_set_hash
Date: Fri, 20 Dec 2013 20:02:13 +0000 [thread overview]
Message-ID: <20131220200213.GA8911@elgon.mountain> (raw)
Hello Tom Herbert,
The patch 0b6807034791: "net: vmxnet3 calls skb_set_hash" from Dec
17, 2013, leads to the following static checker warning:
drivers/net/vmxnet3/vmxnet3_drv.c:1238 vmxnet3_rq_rx_complete()
error: potentially dereferencing uninitialized 'skb'.
drivers/net/vmxnet3/vmxnet3_drv.c
1233 PCI_DMA_FROMDEVICE);
1234
1235 #ifdef VMXNET3_RSS
1236 if (rcd->rssType != VMXNET3_RCD_RSS_TYPE_NONE &&
1237 (adapter->netdev->features & NETIF_F_RXHASH))
1238 skb_set_hash(skb, le32_to_cpu(rcd->rssHash),
^^^
Is it possible to hit this on the first loop iteration before "skb" has
been set?
1239 PKT_HASH_TYPE_L3);
1240 #endif
1241 skb_put(ctx->skb, rcd->len);
1242
1243 /* Immediate refill */
regards,
dan carpenter
reply other threads:[~2013-12-20 20:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220200213.GA8911@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.