All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Lidza Louina <lidza.louina@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	driverdev-devel@linuxdriverproject.org,
	devel@driverdev.osuosl.org
Subject: Re: [PATCH] drivers: dgnc: Include appropriate header file in dgnc_trace.c
Date: Sat, 21 Dec 2013 02:54:23 -0800	[thread overview]
Message-ID: <20131221105423.GE3611@leaf> (raw)
In-Reply-To: <20131221102238.GA3197@rashika>

On Sat, Dec 21, 2013 at 03:52:38PM +0530, Rashika Kheria wrote:
> Include appropriate header file dgnc/dgnc_trace.h in dgnc_trace.c
> because function dgnc_tracer_free() has its prototype declaration in the
> header file.
> 
> This eliminates the following warning in dgnc_trace.c:
> drivers/staging/dgnc/dgnc_trace.c:180:6: warning: no previous prototype for ‘dgnc_tracer_free’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/staging/dgnc/dgnc_trace.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/dgnc/dgnc_trace.c b/drivers/staging/dgnc/dgnc_trace.c
> index a98b7d4..e2164e4 100644
> --- a/drivers/staging/dgnc/dgnc_trace.c
> +++ b/drivers/staging/dgnc/dgnc_trace.c
> @@ -35,6 +35,7 @@
>  #include <linux/vmalloc.h>
>  
>  #include "dgnc_driver.h"
> +#include "dgnc_trace.h"
>  
>  #define TRC_TO_CONSOLE 1
>  
> -- 
> 1.7.9.5
> 

      reply	other threads:[~2013-12-21 10:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-21 10:22 [PATCH] drivers: dgnc: Include appropriate header file in dgnc_trace.c Rashika Kheria
2013-12-21 10:54 ` Josh Triplett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131221105423.GE3611@leaf \
    --to=josh@joshtriplett.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lidza.louina@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rashika.kheria@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.