From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Lidza Louina <lidza.louina@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH 1/2] drivers: dgap: Include appropriate header file in dgap_parse.c
Date: Sat, 21 Dec 2013 02:55:36 -0800 [thread overview]
Message-ID: <20131221105536.GF3611@leaf> (raw)
In-Reply-To: <20131221102550.GA3229@rashika>
On Sat, Dec 21, 2013 at 03:55:50PM +0530, Rashika Kheria wrote:
> Include appropriate header file in dgap/dgap_parse.h in dgap_parse.c
> because functions dgap_parsefile(), dgap_config_get_useintr(),
> dgap_config_get_altpin(), dgap_find_config(),
> dgap_config_get_number_of_ports(), dgap_create_config_string() and
> dgap_get_config_letters() have their prototype declarations in the
> header file.
>
> This eliminates the following warnings in dgap_parse.c:
> drivers/staging/dgap/dgap_parse.c:125:5: warning: no previous prototype for ‘dgap_parsefile’ [-Wmissing-prototypes]
> drivers/staging/dgap/dgap_parse.c:1101:6: warning: no previous prototype for ‘dgap_config_get_useintr’ [-Wmissing-prototypes]
> drivers/staging/dgap/dgap_parse.c:1128:6: warning: no previous prototype for ‘dgap_config_get_altpin’ [-Wmissing-prototypes]
> drivers/staging/dgap/dgap_parse.c:1157:15: warning: no previous prototype for ‘dgap_find_config’ [-Wmissing-prototypes]
> drivers/staging/dgap/dgap_parse.c:1223:6: warning: no previous prototype for ‘dgap_config_get_number_of_ports’ [-Wmissing-prototypes]
> drivers/staging/dgap/dgap_parse.c:1252:7: warning: no previous prototype for ‘dgap_create_config_string’ [-Wmissing-prototypes]
> drivers/staging/dgap/dgap_parse.c:1311:7: warning: no previous prototype for ‘dgap_get_config_letters’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/staging/dgap/dgap_parse.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/dgap/dgap_parse.c b/drivers/staging/dgap/dgap_parse.c
> index ff9d194..36fd93d 100644
> --- a/drivers/staging/dgap/dgap_parse.c
> +++ b/drivers/staging/dgap/dgap_parse.c
> @@ -42,6 +42,7 @@
> #include "dgap_types.h"
> #include "dgap_fep5.h"
> #include "dgap_driver.h"
> +#include "dgap_parse.h"
> #include "dgap_conf.h"
>
>
> --
> 1.7.9.5
>
prev parent reply other threads:[~2013-12-21 10:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-21 10:25 [PATCH 1/2] drivers: dgap: Include appropriate header file in dgap_parse.c Rashika Kheria
2013-12-21 10:55 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131221105536.GF3611@leaf \
--to=josh@joshtriplett.org \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.