From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VunOi-0006nY-Hm for qemu-devel@nongnu.org; Sun, 22 Dec 2013 13:05:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VunOc-0000WS-Jc for qemu-devel@nongnu.org; Sun, 22 Dec 2013 13:05:04 -0500 Received: from hall.aurel32.net ([2001:bc8:30d7:101::1]:51891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VunOc-0000WO-D9 for qemu-devel@nongnu.org; Sun, 22 Dec 2013 13:04:58 -0500 Date: Sun, 22 Dec 2013 19:04:56 +0100 From: Aurelien Jarno Message-ID: <20131222180456.GG4326@ohm.rr44.fr> References: <1386366292-5340-1-git-send-email-rth@twiddle.net> <1386366292-5340-2-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1386366292-5340-2-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH 2/2] cputlb: Tidy memset of arrays List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Sat, Dec 07, 2013 at 10:44:52AM +1300, Richard Henderson wrote: > Don't duplicate the array length computation in the memset > when plain sizeof can produce the correct results. > > Signed-off-by: Richard Henderson > --- > cputlb.c | 2 +- > translate-all.c | 5 ++--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/cputlb.c b/cputlb.c > index d2da404..9270055 100644 > --- a/cputlb.c > +++ b/cputlb.c > @@ -57,7 +57,7 @@ void tlb_flush(CPUArchState *env, int flush_global) > cpu->current_tb = NULL; > > memset(env->tlb_table, -1, sizeof(env->tlb_table)); > - memset(env->tb_jmp_cache, 0, TB_JMP_CACHE_SIZE * sizeof (void *)); > + memset(env->tb_jmp_cache, 0, sizeof(env->tb_jmp_cache)); > > env->tlb_flush_addr = -1; > env->tlb_flush_mask = 0; > diff --git a/translate-all.c b/translate-all.c > index aeda54d..66755b1 100644 > --- a/translate-all.c > +++ b/translate-all.c > @@ -699,11 +699,10 @@ void tb_flush(CPUArchState *env1) > CPU_FOREACH(cpu) { > CPUArchState *env = cpu->env_ptr; > > - memset(env->tb_jmp_cache, 0, TB_JMP_CACHE_SIZE * sizeof(void *)); > + memset(env->tb_jmp_cache, 0, sizeof(env->tb_jmp_cache)); > } > > - memset(tcg_ctx.tb_ctx.tb_phys_hash, 0, > - CODE_GEN_PHYS_HASH_SIZE * sizeof(void *)); > + memset(tcg_ctx.tb_ctx.tb_phys_hash, 0, sizeof(tcg_ctx.tb_ctx.tb_phys_hash)); > page_flush_tb(); > > tcg_ctx.code_gen_ptr = tcg_ctx.code_gen_buffer; Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net