From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] e2fsck: verify s_desc_size is power-of-two value
Date: Mon, 23 Dec 2013 16:07:38 -0500 [thread overview]
Message-ID: <20131223210738.GB11299@thunk.org> (raw)
In-Reply-To: <1387268344-8320-1-git-send-email-adilger@dilger.ca>
On Tue, Dec 17, 2013 at 01:19:03AM -0700, Andreas Dilger wrote:
> Add a LOG2_CHECK mode for check_super_value() so that it is easy
> to verify values that are supposed to be power-of-two values
> (s_desc_size and s_inode_size so far). In ext2fs_check_desc()
> also check for a power-of-two s_desc_size.
>
> Print out s_desc_size in debugfs "stats" and dumpe2fs output, if
> it is non-zero.
>
> It turns out that the s_desc_size validation in check_super_block()
> is not currently used by e2fsck, because the group descriptors are
> verified earlier by ext2fs_check_desc(), and even without an
> explicit check of s_desc_size the group descriptors fail to align
> correctly on disk. It makes sense to keep the check_super_block()
> regardless, in case the code changes at some point in the future.
>
> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied.
- Ted
prev parent reply other threads:[~2013-12-23 21:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 8:19 [PATCH 1/2] e2fsck: verify s_desc_size is power-of-two value Andreas Dilger
2013-12-17 8:19 ` [PATCH 2/2] debugfs, e2fsck: fix s_desc_size handling Andreas Dilger
2013-12-23 21:07 ` Theodore Ts'o
2013-12-23 21:07 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131223210738.GB11299@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.