All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>, xfs@oss.sgi.com
Subject: Re: [PATCH v2 2/3] xfs: add O_TMPFILE support
Date: Tue, 24 Dec 2013 11:55:06 +1100	[thread overview]
Message-ID: <20131224005506.GL3220@dastard> (raw)
In-Reply-To: <1387326161-24530-3-git-send-email-zwu.kernel@gmail.com>

On Wed, Dec 18, 2013 at 08:22:40AM +0800, Zhi Yong Wu wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> 
> Add two functions xfs_create_tmpfile() and xfs_vn_tmpfile()
> to support O_TMPFILE file creation.
> 
> In contrast to xfs_create(), xfs_create_tmpfile() has a different
> log reservation to the regular file creation because there is no
> directory modification, and doesn't check if an entry can be added
> to the directory, but the reservation quotas is required appropriately,
> and finally its inode is added to the unlinked list.
> 
> xfs_vn_tmpfile() add one O_TMPFILE method to VFS interface and directly
> invoke xfs_create_tmpfile().

There's minor stuff I could ask you to change, but I think this is
good enough for initial support of O_TMPFILE.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-12-24  0:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-18  0:22 [PATCH v2 0/3] xfs: add O_TMPFILE support Zhi Yong Wu
2013-12-18  0:22 ` [PATCH v2 1/3] xfs: factor prid related codes into xfs_get_initial_prid() Zhi Yong Wu
2013-12-18  0:22 ` [PATCH v2 2/3] xfs: add O_TMPFILE support Zhi Yong Wu
2013-12-24  0:55   ` Dave Chinner [this message]
2013-12-24  1:58     ` Zhi Yong Wu
2013-12-18  0:22 ` [PATCH v2 3/3] xfs: allow linkat() on O_TMPFILE files Zhi Yong Wu
2013-12-24  0:55   ` Dave Chinner
2013-12-23  1:45 ` [PATCH v2 0/3] xfs: add O_TMPFILE support Zhi Yong Wu
2013-12-26  8:51 ` Christoph Hellwig
     [not found]   ` <20131226085134.GA32660-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2013-12-28 10:04     ` Zhi Yong Wu
2013-12-28 10:04       ` Zhi Yong Wu
2014-01-07 20:49   ` Ben Myers
2014-01-07 20:51     ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2013-12-18  0:15 Zhi Yong Wu
2013-12-18  0:15 ` [PATCH v2 2/3] " Zhi Yong Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131224005506.GL3220@dastard \
    --to=david@fromorbit.com \
    --cc=wuzhy@linux.vnet.ibm.com \
    --cc=xfs@oss.sgi.com \
    --cc=zwu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.