From: Anton Vorontsov <anton@enomsg.org>
To: Jonghwa Lee <jonghwa3.lee@samsung.com>
Cc: linux-pm@vger.kernel.org, dwmw2@infradead.org,
MyungJoo Ham <myungjoo.ham@samsung.com>
Subject: Re: [PATCH 2/3] fuelgauge: max17042: Add IRQF_ONESHOT flag to use default irq handler.
Date: Mon, 23 Dec 2013 19:00:16 -0800 [thread overview]
Message-ID: <20131224030016.GH10223@lizard> (raw)
In-Reply-To: <1387338834-4046-3-git-send-email-jonghwa3.lee@samsung.com>
On Wed, Dec 18, 2013 at 12:53:53PM +0900, Jonghwa Lee wrote:
> This patch adds IRQF_ONESHOT flag to max17042's irq since it uses primary
> default handler. Without this flag, requesting irq will be denied with returning
> error.
>
> Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> ---
Applied, thanks!
> drivers/power/max17042_battery.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
> index bbb2e01..c611ce7 100644
> --- a/drivers/power/max17042_battery.c
> +++ b/drivers/power/max17042_battery.c
> @@ -710,9 +710,9 @@ static int max17042_probe(struct i2c_client *client,
>
> if (client->irq) {
> ret = request_threaded_irq(client->irq, NULL,
> - max17042_thread_handler,
> - IRQF_TRIGGER_FALLING,
> - chip->battery.name, chip);
> + max17042_thread_handler,
> + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> + chip->battery.name, chip);
> if (!ret) {
> regmap_read(chip->regmap, MAX17042_CONFIG, &val);
> val |= CONFIG_ALRT_BIT_ENBL;
> --
> 1.7.9.5
next prev parent reply other threads:[~2013-12-24 3:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 3:53 [PATCH 0/3] fuelgauge: max17042: Update max17042/7 fuelgauge driver Jonghwa Lee
2013-12-18 3:53 ` [PATCH 1/3] fuelgauge: max17042: Do code cleaning to follow kernel code convention Jonghwa Lee
2013-12-24 2:58 ` Anton Vorontsov
2013-12-18 3:53 ` [PATCH 2/3] fuelgauge: max17042: Add IRQF_ONESHOT flag to use default irq handler Jonghwa Lee
2013-12-24 3:00 ` Anton Vorontsov [this message]
2013-12-18 3:53 ` [PATCH 3/3] fuelgauge: max17042: Seperate available property set for different operation Jonghwa Lee
2013-12-24 3:02 ` Anton Vorontsov
2013-12-26 2:19 ` jonghwa3.lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131224030016.GH10223@lizard \
--to=anton@enomsg.org \
--cc=dwmw2@infradead.org \
--cc=jonghwa3.lee@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.