All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: "Lan Yixun (dlan)" <dennis.yxun@gmail.com>
Cc: autofs mailing list <autofs@vger.kernel.org>
Subject: [PATCH 4/5] autofs-5.0.8 - fix rpc_portmap_getport() proto not set
Date: Tue, 24 Dec 2013 16:02:28 +0800	[thread overview]
Message-ID: <20131224080228.8321.27468.stgit@perseus.fritz.box> (raw)
In-Reply-To: <20131224075909.8321.95699.stgit@perseus.fritz.box>

Recent changes to fix libtirpc usage problems when getting a server
exports list cause later server probing to fail.

When getting an exports list a new rpc client is always created for
the query, which includes setting the protocol in the parameters
structure. But when probing availability the client is reused where
possible and the protocol is not set in the parameters structure in
this case.

The rpc_portmap_getport() changes require that the protocol is set
in oder to function.
---
 lib/rpc_subs.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/rpc_subs.c b/lib/rpc_subs.c
index cfb63d2..7c99ea8 100644
--- a/lib/rpc_subs.c
+++ b/lib/rpc_subs.c
@@ -877,6 +877,8 @@ int rpc_portmap_getport(struct conn_info *info,
 
 	memset(&pmap_info, 0, sizeof(struct conn_info));
 
+	pmap_info.proto = proto;
+
 	if (proto == IPPROTO_TCP)
 		pmap_info.timeout.tv_sec = PMAP_TOUT_TCP;
 	else


  parent reply	other threads:[~2013-12-24  8:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-24  8:02 [PATCH 0/5] fyi, here are the patches that I haven't yet committed Ian Kent
2013-12-24  8:02 ` [PATCH 1/5] autofs-5.0.8 - fix ipv6 link local address handling Ian Kent
2013-12-24  8:02 ` [PATCH 2/5] autofs-5.0.8 - fix fix ipv6 libtirpc getport Ian Kent
2013-12-24  8:02 ` [PATCH 3/5] autofs-5.0.8 - get_nfs_info() should query portmapper if port is not given Ian Kent
2013-12-24  8:02 ` Ian Kent [this message]
2013-12-24  8:02 ` [PATCH 5/5] autofs-5.0.8 - fix options compare Ian Kent
2013-12-24  8:38 ` [PATCH 0/5] fyi, here are the patches that I haven't yet committed Dennis Lan (dlan)
2013-12-24  9:04   ` Ian Kent
2013-12-24  9:42     ` Dennis Lan (dlan)
2013-12-24 10:34       ` Ian Kent
2013-12-27  6:11         ` Dennis Lan (dlan)
2013-12-27  6:36           ` Dennis Lan (dlan)
2013-12-27  7:30             ` Dennis Lan (dlan)
2013-12-27  8:56               ` Ian Kent
2013-12-28  2:41                 ` Ian Kent
2013-12-28 12:09                   ` Dennis Lan (dlan)
2013-12-29 11:14                     ` Ian Kent
2013-12-29 11:26                       ` Ian Kent
2013-12-30  7:38                         ` Dennis Lan (dlan)
2013-12-29 11:36               ` Ian Kent
2013-12-30  7:44                 ` Dennis Lan (dlan)
2013-12-27  8:50             ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131224080228.8321.27468.stgit@perseus.fritz.box \
    --to=raven@themaw.net \
    --cc=autofs@vger.kernel.org \
    --cc=dennis.yxun@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.