From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Fan Du <fan.du@windriver.com>
Cc: davem@davemloft.net, steffen.klassert@secunet.com,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] netfilter: IPv4/v6 IPcomp match support
Date: Tue, 24 Dec 2013 19:16:14 +0100 [thread overview]
Message-ID: <20131224181614.GA26270@localhost> (raw)
In-Reply-To: <52B9278D.4020905@windriver.com>
On Tue, Dec 24, 2013 at 02:19:57PM +0800, Fan Du wrote:
> For a packet encapsulated in order of ah->esp->ah->original packet, as you said
> par->thoff is set at esp, that's why netfilter esp has a unified implementation
> in net/netfilter/xt_esp.c, because it's always the last parse header netfilter
> can reach.
>
> The same rule apply with IPcomp, for example,
> (1) ah->ipcomp->original packet
> ^par->thoff
> (2) ipcomp->ah->original packet
> ^par->thoff
>
> Both cases (1) and (2) par->thoff can only point into IPcomp header, so in such
> circumstance, a unified implementation for both IPv4/6 is feasible, and I have
> tested (2) in such implementation, it works anyway.
>
> IMO, a unified implementation suggested by you previous is ok for this round review.
Your right, I forgot the fact that ipcomp "hides" what it
encapsulates, so it's basically the last header we can see.
prev parent reply other threads:[~2013-12-24 18:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 12:18 [PATCH net-next 0/2] netfilter: IPv4/v6 IPcomp match support Fan Du
2013-12-13 12:18 ` [PATCH 1/2] netfilter: add IPv4 IPComp extension " Fan Du
2013-12-13 12:18 ` [PATCH 2/2] netfilter: add IPv6 " Fan Du
2013-12-17 13:05 ` [PATCH net-next 0/2] netfilter: IPv4/v6 IPcomp " Pablo Neira Ayuso
2013-12-19 3:30 ` Fan Du
2013-12-20 9:04 ` Pablo Neira Ayuso
2013-12-20 9:21 ` Fan Du
2013-12-23 12:13 ` Pablo Neira Ayuso
2013-12-24 6:19 ` Fan Du
2013-12-24 18:16 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131224181614.GA26270@localhost \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=fan.du@windriver.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.