All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timo Teras <timo.teras@iki.fi>
To: David Miller <davem@davemloft.net>
Cc: Simon Horman <horms@verge.net.au>, netdev@vger.kernel.org
Subject: net: Loosen constraints for recalculating checksum in skb_segment()
Date: Thu, 26 Dec 2013 09:18:51 +0200	[thread overview]
Message-ID: <20131226091851.463bd189@vostro> (raw)

commit 1cdbcb7957cf9e5f841dbcde9b38fd18a804208b
Author: Simon Horman <horms@verge.net.au>
Date:   Sun May 19 15:46:49 2013 +0000

> net: Loosen constraints for recalculating checksum in skb_segment()
>
> This is a generic solution to resolve a specific problem that I have
> observed.
> 
> If the encapsulation of an skb changes then ability to offload
> checksums may also change. In particular it may be necessary to
> perform checksumming in software.
> 
> An example of such a case is where a non-GRE packet is received but
> is to be encapsulated and transmitted as GRE.

Dave, can you queue this for 3.10-stable.

It was around 3.9 when ip_gre got gso support. This added the bug that
forwarding non-gre to gre with gro+gso+tx offloads enabled does not
work properly - the TCP checksums are not calculated properly without
this patch.

Thanks,
 Timo

                 reply	other threads:[~2013-12-26  7:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131226091851.463bd189@vostro \
    --to=timo.teras@iki.fi \
    --cc=davem@davemloft.net \
    --cc=horms@verge.net.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.