From: "Michael S. Tsirkin" <mst@redhat.com>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/2] acpi unit-test: rebuild aml files functionality
Date: Thu, 26 Dec 2013 14:46:43 +0200 [thread overview]
Message-ID: <20131226124643.GA26225@redhat.com> (raw)
In-Reply-To: <1388060390-16447-1-git-send-email-marcel.a@redhat.com>
On Thu, Dec 26, 2013 at 02:19:48PM +0200, Marcel Apfelbaum wrote:
> Acpi unit-test will fail every time the acpi tables change.
>
> The series adds a script that rebuilds the expected aml files, so the test
> will pass. It also validates the modifications.
>
> The acpi unit test will rebuild the aml tables if TEST_ACPI_REBUILD_AML
> environment variable is set.
OK I had to fix some trailing whitespace, otherwise
looks good.
I applied it all, pls check the pci branch.
> v1 -> v2:
> Addressed Michael S. Tsirkin's comments:
> - added TEST_ prefix to the environment variable
> - some rephrases
>
> Marcel Apfelbaum (2):
> acpi unit-test: added script to rebuild the expected aml files
> acpi unit-test: hook to rebuild expected aml files
>
> tests/acpi-test-data/rebuild-expected-aml.sh | 36 ++++++++++++++++++++++++++++
> tests/acpi-test.c | 30 +++++++++++++++++++----
> 2 files changed, 61 insertions(+), 5 deletions(-)
> create mode 100755 tests/acpi-test-data/rebuild-expected-aml.sh
>
> --
> 1.8.3.1
next prev parent reply other threads:[~2013-12-26 12:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-26 12:19 [Qemu-devel] [PATCH v2 0/2] acpi unit-test: rebuild aml files functionality Marcel Apfelbaum
2013-12-26 12:19 ` [Qemu-devel] [PATCH v2 1/2] acpi unit-test: added script to rebuild the expected aml files Marcel Apfelbaum
2013-12-26 13:54 ` Michael S. Tsirkin
2013-12-26 12:19 ` [Qemu-devel] [PATCH v2 2/2] acpi unit-test: hook to rebuild " Marcel Apfelbaum
2013-12-26 12:46 ` Michael S. Tsirkin [this message]
2013-12-26 13:24 ` [Qemu-devel] [PATCH v2 0/2] acpi unit-test: rebuild aml files functionality Marcel Apfelbaum
2013-12-26 13:53 ` Michael S. Tsirkin
2013-12-26 14:09 ` Marcel Apfelbaum
2013-12-26 15:41 ` Michael S. Tsirkin
2013-12-26 15:58 ` Marcel Apfelbaum
2013-12-26 16:12 ` Michael S. Tsirkin
2013-12-26 16:51 ` Michael S. Tsirkin
2013-12-26 17:15 ` Marcel Apfelbaum
2013-12-26 18:19 ` Michael S. Tsirkin
2013-12-26 22:01 ` Marcel Apfelbaum
2013-12-29 12:45 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131226124643.GA26225@redhat.com \
--to=mst@redhat.com \
--cc=marcel.a@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.