From: Theodore Ts'o <tytso@mit.edu>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Robert Yang <liezhi.yang@windriver.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 01/10] mke2fs.c: add an option: -d root-directory
Date: Thu, 26 Dec 2013 11:07:34 -0500 [thread overview]
Message-ID: <20131226160734.GB23928@thunk.org> (raw)
In-Reply-To: <1387825697.5088.62.camel@dvhart-mobl4.amr.corp.intel.com>
On Mon, Dec 23, 2013 at 11:08:17AM -0800, Darren Hart wrote:
> On Mon, 2013-12-23 at 07:09 -0500, Robert Yang wrote:
> > This option is used for adding the files from a given directory (the
> > root-directory) to the filesystem, it is similiar to genext2fs, but
> > genext2fs doesn't fully support ext4.
> >
> > This commit describes the skeleton of the implementation:
>
> This approach strikes me as a bit odd. We're adding an option and empty
> functions, rather than fleshing them out at the same time. What is the
> motivation for separating this from the actual implementation? At the
> very least the -d option shouldn't be added until it is functional - at
> the end of the series...
I think this approach was used because I complained that intermediate
versions of the commits didn't compile, and this makes bisection
harder.
I'm not going to be that picky about the specific order, though, so
long as after each commit, the result compiles and passes the
regression test suite, although adding support for -d at the very end
does make sense. Or you could only support directories and regular
files, and then add support for symlinks, special files, etc.
Cheers,
- Ted
next prev parent reply other threads:[~2013-12-26 16:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 12:09 [PATCH 00/10] e2fsprogs/mke2fs: add an option: -d root-directory Robert Yang
2013-12-23 12:09 ` [PATCH 01/10] mke2fs.c: " Robert Yang
2013-12-23 19:08 ` Darren Hart
2013-12-24 1:52 ` Robert Yang
2013-12-26 16:07 ` Theodore Ts'o [this message]
2013-12-23 12:09 ` [PATCH 02/10] misc/create_inode.c: copy files recursively Robert Yang
2013-12-23 12:09 ` [PATCH 03/10] misc/create_inode.c: create special file Robert Yang
2013-12-23 12:09 ` [PATCH 04/10] misc/create_inode.c: create symlink Robert Yang
2013-12-23 19:27 ` Darren Hart
2013-12-23 12:09 ` [PATCH 05/10] misc/create_inode.c: copy regular file Robert Yang
2013-12-23 19:32 ` Darren Hart
2013-12-26 16:03 ` Theodore Ts'o
2013-12-27 1:48 ` Robert Yang
2013-12-23 12:09 ` [PATCH 06/10] misc/create_inode.c: create directory Robert Yang
2013-12-23 19:35 ` Darren Hart
2013-12-23 12:09 ` [PATCH 07/10] misc/create_inode.c: set owner/mode/time for the inode Robert Yang
2013-12-23 12:09 ` [PATCH 08/10] misc/create_inode.c: handle hardlinks Robert Yang
2013-12-23 12:09 ` [PATCH 09/10] debugfs: use the functions in misc/create_inode.c Robert Yang
2013-12-23 12:10 ` [PATCH 10/10] mke2fs.8.in: update the manual for the -d option Robert Yang
2013-12-23 19:05 ` [PATCH 00/10] e2fsprogs/mke2fs: add an option: -d root-directory Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131226160734.GB23928@thunk.org \
--to=tytso@mit.edu \
--cc=dvhart@linux.intel.com \
--cc=liezhi.yang@windriver.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.