All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>,
	David Miller <davem@davemloft.net>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH net-next] netfilter: xtables make functions local
Date: Fri, 27 Dec 2013 12:09:37 -0800	[thread overview]
Message-ID: <20131227120937.702bc383@nehalam.linuxnetplumber.net> (raw)

A couple of functions only used in x_tables, don't need to be global

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

---
 include/linux/netfilter/x_tables.h |    2 --
 net/netfilter/x_tables.c           |    6 ++----
 2 files changed, 2 insertions(+), 6 deletions(-)

--- a/include/linux/netfilter/x_tables.h	2013-12-24 15:14:54.502174551 -0800
+++ b/include/linux/netfilter/x_tables.h	2013-12-24 15:16:01.889269178 -0800
@@ -255,8 +255,6 @@ struct xt_table_info *xt_replace_table(s
 				       struct xt_table_info *newinfo,
 				       int *error);
 
-struct xt_match *xt_find_match(u8 af, const char *name, u8 revision);
-struct xt_target *xt_find_target(u8 af, const char *name, u8 revision);
 struct xt_match *xt_request_find_match(u8 af, const char *name, u8 revision);
 struct xt_target *xt_request_find_target(u8 af, const char *name, u8 revision);
 int xt_find_revision(u8 af, const char *name, u8 revision, int target,
--- a/net/netfilter/x_tables.c	2013-12-24 15:14:54.502174551 -0800
+++ b/net/netfilter/x_tables.c	2013-12-24 15:16:01.889269178 -0800
@@ -189,7 +189,7 @@ EXPORT_SYMBOL(xt_unregister_matches);
  */
 
 /* Find match, grabs ref.  Returns ERR_PTR() on error. */
-struct xt_match *xt_find_match(u8 af, const char *name, u8 revision)
+static struct xt_match *xt_find_match(u8 af, const char *name, u8 revision)
 {
 	struct xt_match *m;
 	int err = -ENOENT;
@@ -216,7 +216,6 @@ struct xt_match *xt_find_match(u8 af, co
 
 	return ERR_PTR(err);
 }
-EXPORT_SYMBOL(xt_find_match);
 
 struct xt_match *
 xt_request_find_match(uint8_t nfproto, const char *name, uint8_t revision)
@@ -234,7 +233,7 @@ xt_request_find_match(uint8_t nfproto, c
 EXPORT_SYMBOL_GPL(xt_request_find_match);
 
 /* Find target, grabs ref.  Returns ERR_PTR() on error. */
-struct xt_target *xt_find_target(u8 af, const char *name, u8 revision)
+static struct xt_target *xt_find_target(u8 af, const char *name, u8 revision)
 {
 	struct xt_target *t;
 	int err = -ENOENT;
@@ -261,7 +260,6 @@ struct xt_target *xt_find_target(u8 af,
 
 	return ERR_PTR(err);
 }
-EXPORT_SYMBOL(xt_find_target);
 
 struct xt_target *xt_request_find_target(u8 af, const char *name, u8 revision)
 {

             reply	other threads:[~2013-12-27 20:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-27 20:09 Stephen Hemminger [this message]
2013-12-28  6:21 ` [PATCH net-next] netfilter: xtables make functions local David Miller
2013-12-28 11:31   ` Jan Engelhardt
2013-12-28 12:50     ` Pablo Neira Ayuso
2013-12-30 17:19 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131227120937.702bc383@nehalam.linuxnetplumber.net \
    --to=stephen@networkplumber.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.