From: Jonathan Nieder <jrnieder@gmail.com>
To: Roman Kagan <rkagan@mail.ru>
Cc: git@vger.kernel.org, Benjamin Pabst <benjamin.pabst85@gmail.com>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH v2] git-svn: workaround for a bug in svn serf backend
Date: Fri, 27 Dec 2013 12:07:08 -0800 [thread overview]
Message-ID: <20131227200708.GD20443@google.com> (raw)
In-Reply-To: <1388131515-3015-1-git-send-email-rkagan@mail.ru>
Roman Kagan wrote:
> Subversion serf backend in versions 1.8.5 and below has a bug that the
> function creating the descriptor of a file change -- add_file() --
> doesn't make a copy of its third argument when storing it on the
> returned descriptor. As a result, by the time this field is used (in
> transactions of file copying or renaming) it may well be released, and
> the memory reused.
>
> One of its possible manifestations is the svn assertion triggering on an
> invalid path, with a message
>
> svn_fspath__skip_ancestor: Assertion `svn_fspath__is_canonical(child_fspath)' failed.
[...]
Makes sense. Perhaps also worth mentioning that this is fixed by
r1553376, but no need to reroll just for that.
> Cc: Benjamin Pabst <benjamin.pabst85@gmail.com>
> Cc: Eric Wong <normalperson@yhbt.net>
> Cc: Jonathan Nieder <jrnieder@gmail.com>
No need for these lines --- the mail header already keeps track of who
is being cc-ed.
> Signed-off-by: Roman Kagan <rkagan@mail.ru>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
next prev parent reply other threads:[~2013-12-27 20:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAM-uYMgy8duxdGY8rbCJv9To3FFMAUDv22nnzbQ+e3QrTCLLpQ@mail.gmail.com>
[not found] ` <CAM-uYMigCTK=j3HkyT0F=jtDoDERdtkpZiTXRvBhSHJW3edJ-w@mail.gmail.com>
2013-11-14 15:26 ` Fwd: Error with git-svn pushing a rename Benjamin Pabst
2013-11-15 7:34 ` Andreas Stricker
[not found] ` <CAM-uYMgn4SGqurqRG-RDiicLxpf9NfTPUvNn9FaFUUbxFRJsZw@mail.gmail.com>
2013-11-15 13:36 ` Andreas Stricker
2013-11-15 22:53 ` Jonathan Nieder
2013-11-17 22:55 ` Andreas Stricker
2013-11-20 22:10 ` Benjamin Pabst
2013-12-24 21:11 ` Roman Kagan
2013-12-25 10:52 ` Roman Kagan
2013-12-25 13:13 ` Roman Kagan
2013-12-25 16:31 ` Thomas Rast
2013-12-26 12:05 ` [PATCH] git-svn: workaround for a bug in svn serf backend Roman Kagan
2013-12-26 20:28 ` Jonathan Nieder
2013-12-27 6:09 ` Roman Kagan
2013-12-27 7:52 ` Roman Kagan
2013-12-27 8:05 ` [PATCH v2] " Roman Kagan
2013-12-27 20:07 ` Jonathan Nieder [this message]
2013-12-27 20:34 ` Eric Wong
2013-12-27 22:22 ` Junio C Hamano
2013-12-28 9:58 ` Roman Kagan
2013-12-30 19:44 ` Junio C Hamano
2013-12-31 7:20 ` Roman Kagan
2014-01-17 11:32 ` Roman Kagan
2014-01-17 19:23 ` Junio C Hamano
2014-01-06 15:51 ` Andreas Stricker
2013-12-30 12:20 ` [PATCH] " Thomas Rast
2013-12-30 16:01 ` Roman Kagan
2013-11-18 17:59 ` Fwd: Error with git-svn pushing a rename Benjamin Pabst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131227200708.GD20443@google.com \
--to=jrnieder@gmail.com \
--cc=benjamin.pabst85@gmail.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=rkagan@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.