From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 9/9] grub: align splashscreen handling with iso9660 code
Date: Sat, 28 Dec 2013 22:14:25 +0100 [thread overview]
Message-ID: <20131228211425.GM3373@free.fr> (raw)
In-Reply-To: <1388242600-2580-10-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2013-12-28 15:56 +0100, Thomas Petazzoni spake thusly:
> This commit aligns the Grub handling of the splash screen with what is
> done in the ISO9660 code.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> boot/grub/grub.mk | 5 ++++-
> boot/grub/menu.lst | 11 +++++++----
> 2 files changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/boot/grub/grub.mk b/boot/grub/grub.mk
> index 3be4a74..d22df88 100644
> --- a/boot/grub/grub.mk
> +++ b/boot/grub/grub.mk
> @@ -82,7 +82,10 @@ GRUB_CONF_OPT = \
> ifeq ($(BR2_TARGET_GRUB_SPLASH),y)
> define GRUB_INSTALL_SPLASH
> cp boot/grub/splash.xpm.gz $(TARGET_DIR)/boot/grub/
> - $(SED) 's/^#splashimage/splashimage/' $(TARGET_DIR)/boot/grub/menu.lst
> +endef
> +else
> +define GRUB_INSTALL_SPLASH
> + $(SED) '/^splashimage/d' $(TARGET_DIR)/boot/grub/menu.lst
> endef
> endif
>
> diff --git a/boot/grub/menu.lst b/boot/grub/menu.lst
> index 7845fee..09426f2 100644
> --- a/boot/grub/menu.lst
> +++ b/boot/grub/menu.lst
> @@ -1,7 +1,10 @@
> -default=0
> -timeout=5
> -#splashimage=(hd0,0)/boot/grub/splash.xpm.gz
> -hiddenmenu
> +default 0
> +timeout 10
> +color cyan/blue white/blue
> +splashimage (hd0,0)/boot/grub/splash.xpm.gz
> +foreground 000000
> +background cccccc
Ditto, see my reply to the previous patch.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2013-12-28 21:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-28 14:56 [Buildroot] [PATCH 0/9] iso9660/grub improvements Thomas Petazzoni
2013-12-28 14:56 ` [Buildroot] [PATCH 1/9] fs/iso9660: put the Buildroot boot entry first in Grub menu.lst Thomas Petazzoni
2013-12-28 19:33 ` Yann E. MORIN
2013-12-28 14:56 ` [Buildroot] [PATCH 2/9] grub: enclose network driver options in a sub-menu Thomas Petazzoni
2013-12-28 19:35 ` Yann E. MORIN
2013-12-28 14:56 ` [Buildroot] [PATCH 3/9] grub: replace string option for filesystem selection by booleans Thomas Petazzoni
2013-12-28 19:38 ` Yann E. MORIN
2013-12-28 14:56 ` [Buildroot] [PATCH 4/9] fs/iso9660: select ISO9660 support in Grub Thomas Petazzoni
2013-12-28 19:38 ` Yann E. MORIN
2013-12-28 14:56 ` [Buildroot] [PATCH 5/9] linux: enable initrd/initramfs support when cpio rootfs is chosen Thomas Petazzoni
2013-12-28 19:49 ` Yann E. MORIN
2013-12-29 10:13 ` Thomas Petazzoni
2013-12-29 16:34 ` Yann E. MORIN
2013-12-29 17:00 ` Thomas Petazzoni
2013-12-28 14:56 ` [Buildroot] [PATCH 6/9] fs/iso9660: do not use an initrd in iso image when using initramfs Thomas Petazzoni
2013-12-28 14:56 ` [Buildroot] [PATCH 7/9] grub: really disable splash screen support Thomas Petazzoni
2013-12-28 19:50 ` Yann E. MORIN
2013-12-28 14:56 ` [Buildroot] [PATCH 8/9] fs/iso9660: add Grub splashscreen support Thomas Petazzoni
2013-12-28 21:09 ` Yann E. MORIN
2013-12-29 10:24 ` Thomas Petazzoni
2013-12-29 16:45 ` Yann E. MORIN
2013-12-29 17:02 ` Thomas Petazzoni
2013-12-28 14:56 ` [Buildroot] [PATCH 9/9] grub: align splashscreen handling with iso9660 code Thomas Petazzoni
2013-12-28 21:14 ` Yann E. MORIN [this message]
2013-12-29 10:25 ` Thomas Petazzoni
2013-12-29 11:19 ` [Buildroot] [PATCH 0/9] iso9660/grub improvements Thomas Petazzoni
2013-12-29 16:59 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131228211425.GM3373@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.