From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from arkanian.console-pimps.org ([212.110.184.194]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VxG4O-0000yj-VE for kexec@lists.infradead.org; Sun, 29 Dec 2013 13:06:17 +0000 Date: Sun, 29 Dec 2013 13:05:46 +0000 From: Matt Fleming Subject: Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data Message-ID: <20131229130546.GA2618@console-pimps.org> References: <1387533742-18018-1-git-send-email-dyoung@redhat.com> <1387533742-18018-10-git-send-email-dyoung@redhat.com> <20131221160416.GD29501@console-pimps.org> <20131223020958.GB3760@dhcp-16-126.nay.redhat.com> <20131223080741.GB28919@console-pimps.org> <20131225031259.GB6333@dhcp-16-126.nay.redhat.com> <20131225033205.GC6333@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131225033205.GC6333@dhcp-16-126.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Dave Young Cc: mjg59@srcf.ucam.org, msalter@redhat.com, linux-efi@vger.kernel.org, toshi.kani@hp.com, greg@kroah.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, leif.lindholm@linaro.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com, akpm@linux-foundation.org, mingo@kernel.org, vgoyal@redhat.com On Wed, 25 Dec, at 11:32:05AM, Dave Young wrote: > > Matt, if you want to remove the map[0] please fold below one line > patch? I have no strong opinion. > > Index: linux/arch/x86/include/asm/efi.h > =================================================================== > --- linux.orig/arch/x86/include/asm/efi.h > +++ linux/arch/x86/include/asm/efi.h > @@ -139,7 +139,6 @@ struct efi_setup_data { > u64 tables; > u64 smbios; > u64 reserved[8]; > - efi_memory_desc_t map[0]; > }; > > extern u64 efi_setup; Thanks Dave, I will fold this in. I would suggest updating your kexec-tools patches so that the two structures are in sync. -- Matt Fleming, Intel Open Source Technology Center _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data Date: Sun, 29 Dec 2013 13:05:46 +0000 Message-ID: <20131229130546.GA2618@console-pimps.org> References: <1387533742-18018-1-git-send-email-dyoung@redhat.com> <1387533742-18018-10-git-send-email-dyoung@redhat.com> <20131221160416.GD29501@console-pimps.org> <20131223020958.GB3760@dhcp-16-126.nay.redhat.com> <20131223080741.GB28919@console-pimps.org> <20131225031259.GB6333@dhcp-16-126.nay.redhat.com> <20131225033205.GC6333@dhcp-16-126.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20131225033205.GC6333-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Dave Young Cc: mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, toshi.kani-VXdhtT5mjnY@public.gmane.org, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: linux-efi@vger.kernel.org On Wed, 25 Dec, at 11:32:05AM, Dave Young wrote: > > Matt, if you want to remove the map[0] please fold below one line > patch? I have no strong opinion. > > Index: linux/arch/x86/include/asm/efi.h > =================================================================== > --- linux.orig/arch/x86/include/asm/efi.h > +++ linux/arch/x86/include/asm/efi.h > @@ -139,7 +139,6 @@ struct efi_setup_data { > u64 tables; > u64 smbios; > u64 reserved[8]; > - efi_memory_desc_t map[0]; > }; > > extern u64 efi_setup; Thanks Dave, I will fold this in. I would suggest updating your kexec-tools patches so that the two structures are in sync. -- Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752279Ab3L2NF4 (ORCPT ); Sun, 29 Dec 2013 08:05:56 -0500 Received: from arkanian.console-pimps.org ([212.110.184.194]:38962 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751968Ab3L2NFy (ORCPT ); Sun, 29 Dec 2013 08:05:54 -0500 Date: Sun, 29 Dec 2013 13:05:46 +0000 From: Matt Fleming To: Dave Young Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, bp@alien8.de, greg@kroah.com, toshi.kani@hp.com, akpm@linux-foundation.org, mingo@kernel.org, msalter@redhat.com, leif.lindholm@linaro.org Subject: Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data Message-ID: <20131229130546.GA2618@console-pimps.org> References: <1387533742-18018-1-git-send-email-dyoung@redhat.com> <1387533742-18018-10-git-send-email-dyoung@redhat.com> <20131221160416.GD29501@console-pimps.org> <20131223020958.GB3760@dhcp-16-126.nay.redhat.com> <20131223080741.GB28919@console-pimps.org> <20131225031259.GB6333@dhcp-16-126.nay.redhat.com> <20131225033205.GC6333@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131225033205.GC6333@dhcp-16-126.nay.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Dec, at 11:32:05AM, Dave Young wrote: > > Matt, if you want to remove the map[0] please fold below one line > patch? I have no strong opinion. > > Index: linux/arch/x86/include/asm/efi.h > =================================================================== > --- linux.orig/arch/x86/include/asm/efi.h > +++ linux/arch/x86/include/asm/efi.h > @@ -139,7 +139,6 @@ struct efi_setup_data { > u64 tables; > u64 smbios; > u64 reserved[8]; > - efi_memory_desc_t map[0]; > }; > > extern u64 efi_setup; Thanks Dave, I will fold this in. I would suggest updating your kexec-tools patches so that the two structures are in sync. -- Matt Fleming, Intel Open Source Technology Center