From: Baruch Siach <baruch@tkos.co.il>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: linux-watchdog@vger.kernel.org, Jamie Iles <jamie@jamieiles.com>
Subject: Re: [PATCH] watchdog: dw_wdt: remove build dependencies
Date: Mon, 30 Dec 2013 11:01:15 +0200 [thread overview]
Message-ID: <20131230090115.GA3930@tarshish> (raw)
In-Reply-To: <20131230083755.GM10136@spo001.leaseweb.com>
Hi Wim,
On Mon, Dec 30, 2013 at 09:37:55AM +0100, Wim Van Sebroeck wrote:
> If this is ARM hardware, then this should have the dependency "depends on
> ARM".
> Only if other architectures start using this watchdog device, then the
> "depends on ARM" can go.
Well, we intend to use this driver on Xtensa platform, does this count?
As a general rule wouldn't it be better to have the widest possible build
coverage, and encourage arch neutral driver coding?
baruch
> > There is nothing ARM specific in this driver. Also, clk.h now includes
> > stubs
> > for !CONFIG_HAVE_CLK, so the driver should build anyway.
> >
> > Cc: Jamie Iles <jamie@jamieiles.com>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > drivers/watchdog/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > index 5be6e91..5ffac39 100644
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
> > @@ -214,7 +214,6 @@ config SA1100_WATCHDOG
> >
> > config DW_WATCHDOG
> > tristate "Synopsys DesignWare watchdog"
> > - depends on ARM && HAVE_CLK
> > help
> > Say Y here if to include support for the Synopsys DesignWare
> > watchdog timer found in many ARM chips.
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2013-12-30 9:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 7:10 [PATCH] watchdog: dw_wdt: remove build dependencies Baruch Siach
2013-12-30 8:37 ` Wim Van Sebroeck
2013-12-30 9:01 ` Baruch Siach [this message]
2013-12-30 11:03 ` Wim Van Sebroeck
2013-12-30 11:30 ` Baruch Siach
2013-12-30 12:08 ` Wim Van Sebroeck
2013-12-30 12:16 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131230090115.GA3930@tarshish \
--to=baruch@tkos.co.il \
--cc=jamie@jamieiles.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.