All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liu Bo <bo.li.liu@oracle.com>
To: Martin Steigerwald <Martin@lichtvoll.de>
Cc: linux-btrfs@vger.kernel.org,
	Marcel Ritter <ritter.marcel@gmail.com>,
	Christian Robert <christian.robert@polymtl.ca>,
	"alanqk@gmail.com" <alanqk@gmail.com>
Subject: Re: [PATCH] Btrfs-progs: add dedup subcommand
Date: Tue, 31 Dec 2013 11:18:36 +0800	[thread overview]
Message-ID: <20131231031835.GA30107@localhost.localdomain> (raw)
In-Reply-To: <10456749.stdChJhbpX@merkaba>

On Mon, Dec 30, 2013 at 12:34:42PM +0100, Martin Steigerwald wrote:
> Am Montag, 30. Dezember 2013, 16:12:55 schrieben Sie:
> > This adds deduplication subcommands, 'btrfs dedup command <path>',
> > including enable/disable/on/off.
> 
> Nice. Looking forward to test it.

Well, I just got a report from another user, Marcel, who still got ENOSPC errors with this
around of patch set, so it seems that I don't really fix that bug, I guess I
have to work harder on this :-(

>  
> > - btrfs dedup enable
> > Create the dedup tree, and it's the very first step when you're going to use
> > the dedup feature.
> > 
> > - btrfs dedup disable
> > Delete the dedup tree, after this we're not able to use dedup any more
> > unless you enable it again.
> 
> So if deduplication has been switched on for a while, btrfs dedup disable will 
> cause BTRFS to undo the deduplication (and thus require more space for the 
> same amount of data)?

No, it remains unchanged, and the data is independent of dedupe, so you can read
them without any problems.

Happy new year.

Thanks,
-liubo

  reply	other threads:[~2013-12-31  3:18 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30  8:12 [RFC PATCH v8 00/14] Online(inband) data deduplication Liu Bo
2013-12-30  8:12 ` [PATCH v8 01/14] Btrfs: skip merge part for delayed data refs Liu Bo
2013-12-30  8:12 ` [PATCH v8 02/14] Btrfs: improve the delayed refs process in rm case Liu Bo
2013-12-30  8:12 ` [PATCH v8 03/14] Btrfs: introduce a head ref rbtree Liu Bo
2013-12-30  8:12 ` [PATCH v8 04/14] Btrfs: disable qgroups accounting when quata_enable is 0 Liu Bo
2013-12-30  8:12 ` [PATCH v8 05/14] Btrfs: introduce dedup tree and relatives Liu Bo
2013-12-30  8:12 ` [PATCH v8 06/14] Btrfs: introduce dedup tree operations Liu Bo
2013-12-30  8:12 ` [PATCH v8 07/14] Btrfs: introduce dedup state Liu Bo
2013-12-30  8:12 ` [PATCH v8 08/14] Btrfs: make ordered extent aware of dedup Liu Bo
2013-12-30  8:12 ` [PATCH v8 09/14] Btrfs: online(inband) data dedup Liu Bo
2013-12-30  8:12 ` [PATCH v8 10/14] Btrfs: skip dedup reference during backref walking Liu Bo
2013-12-30  8:12 ` [PATCH v8 11/14] Btrfs: don't return space for dedup extent Liu Bo
2013-12-30  8:12 ` [PATCH v8 12/14] Btrfs: add ioctl of dedup control Liu Bo
2013-12-30  8:12 ` [PATCH v8 13/14] Btrfs: fix dedupe 'ENOSPC' problem Liu Bo
2013-12-30  8:12 ` [PATCH v8 14/14] Btrfs: fix a crash of dedup ref Liu Bo
2013-12-30  8:12 ` [PATCH] Btrfs-progs: add dedup subcommand Liu Bo
2013-12-30 11:34   ` Martin Steigerwald
2013-12-31  3:18     ` Liu Bo [this message]
2013-12-31  3:24     ` Kai Krakow
2014-01-14 17:34   ` David Sterba
2014-01-15  1:35     ` Liu Bo
2014-01-17 16:14       ` David Sterba
2014-01-02 14:32 ` [RFC PATCH v8 00/14] Online(inband) data deduplication Konstantinos Skarlatos
2014-01-02 15:02   ` Konstantinos Skarlatos
2014-02-25 19:22 ` Jannis Achstetter
2014-02-25 19:39   ` Jannis Achstetter
2014-02-26 20:20   ` Jannis Achstetter
2014-02-27  2:39     ` Liu Bo
  -- strict thread matches above, loose matches on Subject: below --
2013-07-31 15:37 [RFC PATCH v5 0/5] Online " Liu Bo
2013-07-31 15:37 ` [PATCH] Btrfs-progs: add dedup subcommand Liu Bo
2013-07-31 16:30   ` Stefan Behrens
2013-08-01 10:17     ` Liu Bo
2013-08-01 22:01   ` Mark Fasheh
2013-08-02  2:29     ` Liu Bo
2013-05-14 12:08 [RFC PATCH V4 0/2] Online data deduplication Liu Bo
2013-05-14 12:08 ` [PATCH] Btrfs-progs: add dedup subcommand Liu Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131231031835.GA30107@localhost.localdomain \
    --to=bo.li.liu@oracle.com \
    --cc=Martin@lichtvoll.de \
    --cc=alanqk@gmail.com \
    --cc=christian.robert@polymtl.ca \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=ritter.marcel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.