From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH] ASoC: generic: add generic compound card with DT support Date: Tue, 31 Dec 2013 13:36:10 +0100 Message-ID: <20131231133610.2d14bc29@armhf> References: <20131231113138.102044cf@armhf> <20131231115927.GK31886@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp2-g21.free.fr (smtp2-g21.free.fr [212.27.42.2]) by alsa0.perex.cz (Postfix) with ESMTP id 90F0126171B for ; Tue, 31 Dec 2013 13:37:06 +0100 (CET) In-Reply-To: <20131231115927.GK31886@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen , Liam Girdwood , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org T24gVHVlLCAzMSBEZWMgMjAxMyAxMTo1OToyNyArMDAwMApNYXJrIEJyb3duIDxicm9vbmllQGtl cm5lbC5vcmc+IHdyb3RlOgoKPiA+IFRoaXMgY29kZSB3YXMgZmlyc3QgZGV2ZWxvcHBlZCBvbiB0 aGUgZ2VuZXJpYyBzaW1wbGUgY2FyZCwgYnV0IGl0cwo+ID4gcmVjZW50IERUIGV4dGVuc2lvbiBj YW5ub3QgYmUgZWFzaWx5IGV4dGVuZGVkIGFnYWluIHRvIHN1cHBvcnQgY29tcG91bmQKPiA+IGNh cmRzIGFzIHRoZSBvbmUgaW4gdGhlIEN1Ym94LiAgCj4gCj4gSXQgd291bGQgaGF2ZSBiZWVuIHVz ZWZ1bCB0byBoYXZlIHByb3ZpZGVkIHRoYXQgZmVlZGJhY2sgYXQgdGhlIHRpbWUKPiByYXRoZXIg dGhhbiB3YWl0aW5nIHVudGlsIGFmdGVyIGl0IGhhZCBiZWVuIG1lcmdlZCAtIGl0IHdhcyBpbiBy ZXZpZXcKPiBmb3IgbG9uZyBlbm91Z2guICBJdCB3b3VsZCBhbHNvIGJlIGdvb2QgdG8gYXJ0aWN1 bGF0ZSB0aGUgaXNzdWVzIHdpdGgKPiB0aGUgYmluZGluZyByYXRoZXIgdGhhbiBzaW1wbHkgc3Rh dGluZyB0aGV5IGV4aXN0LCBhbmQgdG8gY29uc2lkZXIKPiBhZGRpbmcgYSBzZWNvbmQgYmluZGlu ZyB0byB0aGUgZXhpc3RpbmcgZ2VuZXJpYyBjYXJkIHJhdGhlciB0aGFuIGFkZGluZwo+IGEgdG90 YWxseSBuZXcgY2FyZC4KClNvcnJ5LCBJIHNwZW50IGEgbG90IG9mIHRpbWUgb24gRFBDTSwgYW5k IEkgd2FzIG5vdCB5ZXQgcmVhZHkgdG8gcHJvcG9zZQpzb21ldGhpbmcgd2hlbiB5b3UgYWNjZXB0 ZWQgS3VuaW5vcmkncyBwYXRjaC4KCj4gUGxlYXNlIGFsc28gcmVtZW1iZXIgdGhhdCBhbGwgRFQg cGF0Y2hlcyBuZWVkIHRvIGJlIHJldmlld2VkIGJ5IHRoZSBEVAo+IHBlb3BsZSwgeW91J3ZlIG5v dCBDQ2VkIGVpdGhlciB0aGVtIG9yIHRoZSBsaXN0Lgo+IAo+ID4gKyAgLSBmcm9udC1lbmQgb3Ig YmFjay1lbmQ6IHByZXNlbnQgaWYgdGhlIERBSSBsaW5rIGRlc2NyaWJlcyByZXNwLgo+ID4gKwkJ YSBmcm9udC1lbmQgQ1BVIERBSSBvciBhIGJhY2stZW5kIENPREVDIERBSSAgCj4gCj4gVGhlc2Ug YXJlIExpbnV4LWludGVybmFsIGNvbmNlcHRzIHdoaWNoIHNob3VsZG4ndCBhcHBlYXIgaW4gYSBE VCBiaW5kaW5nCj4gb3IgYXQgdGhlIHZlcnkgbGVhc3QgbmVlZCBkZWZpbml0aW9uLiAgT25lIHRo aW5nIHRvIGNvbnNpZGVyIGhlcmUgaXMKPiB0aGF0IHRoZXNlIHRoaW5ncyBhcmUgYWxsIGFib3V0 IHRoZSBpbnRlcm5hbHMgb2YgYSBTb0MgYW5kIHlvdSdkCj4gdGhlcmVmb3JlIGV4cGVjdCB0aGF0 IHRoZXkgd291bGQgYmUgZGVmaW5lZCBzZXBhcmF0ZWx5IGZyb20gdGhlIGNhcmQgc28KPiBhcyB0 byBhdm9pZCBoYXZpbmcgdG8gcmVwbGljYXRlIGluZm9ybWF0aW9uIGluIGV2ZXJ5IGNhcmQgdXNp bmcgYSBnaXZlbgo+IFNvQy4KCkRvIHlvdSBtZWFuIHRoYXQsIGFzIERQQ00gY2Fubm90IGJlIGlu IHRoZSBEVCwgdGhlcmUgc2hvdWxkIGJlIGEKc3BlY2lmaWMgZHJpdmVyIGZvciB0aGUgQ3Vib3gg YXVkaW8gY2FyZCAoTWFydmVsbCBBcm1hZGEgNTEwICsgTlhQIEhETUkKdHJhbnNtaXR0ZXIpPwoK LS0gCktlbiBhciBjJ2hlbnRhw7EJfAkgICAgICAqKiBCcmVpemggaGEgTGludXggYXRhdiEgKioK SmVmCQl8CQlodHRwOi8vbW9pbmVqZi5mcmVlLmZyLwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVs QGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753321Ab3LaMhN (ORCPT ); Tue, 31 Dec 2013 07:37:13 -0500 Received: from smtp2-g21.free.fr ([212.27.42.2]:48232 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752929Ab3LaMhL convert rfc822-to-8bit (ORCPT ); Tue, 31 Dec 2013 07:37:11 -0500 Date: Tue, 31 Dec 2013 13:36:10 +0100 From: Jean-Francois Moine To: Mark Brown Cc: Liam Girdwood , Lars-Peter Clausen , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: generic: add generic compound card with DT support Message-ID: <20131231133610.2d14bc29@armhf> In-Reply-To: <20131231115927.GK31886@sirena.org.uk> References: <20131231113138.102044cf@armhf> <20131231115927.GK31886@sirena.org.uk> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Dec 2013 11:59:27 +0000 Mark Brown wrote: > > This code was first developped on the generic simple card, but its > > recent DT extension cannot be easily extended again to support compound > > cards as the one in the Cubox. > > It would have been useful to have provided that feedback at the time > rather than waiting until after it had been merged - it was in review > for long enough. It would also be good to articulate the issues with > the binding rather than simply stating they exist, and to consider > adding a second binding to the existing generic card rather than adding > a totally new card. Sorry, I spent a lot of time on DPCM, and I was not yet ready to propose something when you accepted Kuninori's patch. > Please also remember that all DT patches need to be reviewed by the DT > people, you've not CCed either them or the list. > > > + - front-end or back-end: present if the DAI link describes resp. > > + a front-end CPU DAI or a back-end CODEC DAI > > These are Linux-internal concepts which shouldn't appear in a DT binding > or at the very least need definition. One thing to consider here is > that these things are all about the internals of a SoC and you'd > therefore expect that they would be defined separately from the card so > as to avoid having to replicate information in every card using a given > SoC. Do you mean that, as DPCM cannot be in the DT, there should be a specific driver for the Cubox audio card (Marvell Armada 510 + NXP HDMI transmitter)? -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/