From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 01 Jan 2014 17:10:10 +0100 (CET) Received: from [195.154.112.97] ([195.154.112.97]:52179 "EHLO hall.aurel32.net" rhost-flags-FAIL-FAIL-OK-OK) by eddie.linux-mips.org with ESMTP id S6825722AbaAAQKBEMYex (ORCPT ); Wed, 1 Jan 2014 17:10:01 +0100 Received: from aurel32 by hall.aurel32.net with local (Exim 4.80) (envelope-from ) id 1VyOMn-0005wA-IL; Wed, 01 Jan 2014 17:09:57 +0100 Date: Wed, 1 Jan 2014 17:09:57 +0100 From: Aurelien Jarno To: Huacai Chen Cc: Aaro Koskinen , Ralf Baechle , John Crispin , "Steven J. Hill" , linux-mips@linux-mips.org, Fuxin Zhang , Zhangjin Wu , Hongliang Tao , Hua Yan Subject: Re: [PATCH V15 02/12] MIPS: Loongson: Add basic Loongson-3 CPU support Message-ID: <20140101160957.GA21559@hall.aurel32.net> References: <1387109676-540-1-git-send-email-chenhc@lemote.com> <1387109676-540-3-git-send-email-chenhc@lemote.com> <20131230213354.GA20586@hall.aurel32.net> <20131231151751.GB7429@blackmetal.musicnaut.iki.fi> <20131231154315.GE9794@hall.aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: X-Mailer: Mutt 1.5.21 (2010-09-15) User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 38828 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: aurelien@aurel32.net Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Thanks a lot for that. I haven't found the time to review all the patches from V15 now, but I can directly review the V16 instead when I find the time. Aurelien On Wed, Jan 01, 2014 at 11:04:15PM +0800, Huacai Chen wrote: > V16 will be coming soon. > > > On Tue, Dec 31, 2013 at 11:43 PM, Aurelien Jarno wrote: > > > On Tue, Dec 31, 2013 at 05:17:51PM +0200, Aaro Koskinen wrote: > > > Hi, > > > > > > On Mon, Dec 30, 2013 at 10:33:54PM +0100, Aurelien Jarno wrote: > > > > > switch (c->processor_id & PRID_REV_MASK) { > > > > > case PRID_REV_LOONGSON2E: > > > > > + c->cputype = CPU_LOONGSON2; > > > > > + __cpu_name[cpu] = "ICT Loongson-2E"; > > > > > set_elf_platform(cpu, "loongson2e"); > > > > > break; > > > > > case PRID_REV_LOONGSON2F: > > > > > + c->cputype = CPU_LOONGSON2; > > > > > + __cpu_name[cpu] = "ICT Loongson-2F"; > > > > > set_elf_platform(cpu, "loongson2f"); > > > > > > > > I have mixed feelings about the Loongson-2 name change. On one side > > it's > > > > clearly better to have 2E and 2F instead of 2 V0.2 and 2 V0.3, and it > > > > should have been like that since the beginning. That said changing that > > > > now is kind of breaking the userland. I know that it would break debian > > > > installer support for example, though that should not be a real problem > > > > as we ship the installer with a given kernel version. I don't know if > > > > there are other usages that can cause a problem. Any opinion from > > > > others? > > > > > > Changing it would break also GCC's -march=native detection. So NACK. > > > > Indeed, good catch. That said it already looks for both Godson2 and > > Loongson-2, so I guess such a patch is acceptable if someone updates GCC > > and waits a few years before submitting it again. > > > > -- > > Aurelien Jarno GPG: 1024D/F1BCDB73 > > aurelien@aurel32.net http://www.aurel32.net > > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net