From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id D26CC7F55 for ; Wed, 1 Jan 2014 19:12:52 -0600 (CST) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 4E1EBAC007 for ; Wed, 1 Jan 2014 17:12:49 -0800 (PST) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id EC7edjyqRUGg9Rba for ; Wed, 01 Jan 2014 17:12:47 -0800 (PST) Date: Thu, 2 Jan 2014 12:12:43 +1100 From: Dave Chinner Subject: Re: [PATCH 2/10] xfs: xfs_bulkstat_single consolidation Message-ID: <20140102011243.GO20579@dastard> References: <52BEB3E7.2080706@oracle.com> <52C1BCE5.1070707@sgi.com> <52C293A5.1000606@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <52C293A5.1000606@oracle.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Jeff Liu Cc: Mark Tinguely , "xfs@oss.sgi.com" T24gVHVlLCBEZWMgMzEsIDIwMTMgYXQgMDU6NTE6MzNQTSArMDgwMCwgSmVmZiBMaXUgd3JvdGU6 Cj4gT24gMjAxM+W5tDEy5pyIMzHml6UgMDI6MzUsIE1hcmsgVGluZ3VlbHkgd3JvdGU6Cj4gPiBP biAxMi8yOC8xMyAwNToyMCwgSmVmZiBMaXUgd3JvdGU6Cj4gPj4gRnJvbTogSmllIExpdTxqZWZm LmxpdUBvcmFjbGUuY29tPgo+ID4+Cj4gPj4gSW4geGZzX2J1bGtzdGF0X3NpbmdsZSgpLCB4ZnNf YnVsa3N0YXRfb25lKCkgYW5kIHhmc19idWxrc3RhdCgpIG1pZ2h0Cj4gPj4gcmV0dXJuIGRpZmZl cmVudCBlcnJvciBpZiBlaXRoZXIgY2FsbCBmYWlsZWQsIHdlJ2QgYmV0dGVyIHJldHVybiB0aGUK PiA+PiBwcm9wZXIgZXJyb3IgaW4gdGhpcyBjYXNlLiAgTW9yZW92ZXIsIHRoZSBmdW5jdGlvbiBh cmd1bWVudCBkb25lIGlzCj4gPj4gdXNlbGVzcyBpbiB0ZXJtcyBvZiB4ZnNfaW9jX2J1bGtzdGF0 KCksIGhlbmNlIHdlIGNhbiBnZXQgcmlkIG9mIGl0Lgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTog SmllIExpdTxqZWZmLmxpdUBvcmFjbGUuY29tPgo+ID4+IC0tLQo+ID4gCj4gPiBZZXMsIEkga25v dyBkbWFwaSBpcyBub3QgbG92ZWQgaGVyZSBidXQgU0dJIHN0aWxsIHVzZXMgaXQgYW5kIGl0IHdh bnRzCj4gPiB0aGUgZG9uZSBmbGFnIHN0aWxsLi4KPiBNeSBtaXN0YWtlLiAgQXQgdGhhdCB0aW1l LCBJIG5vdGljZWQgdGhhdCB0aGVyZSBoYXMgY29tbWVudHMgYWJvdXQgdGhpcwo+IGluIHhmc19p b2NfYnVsa3N0YXQoKSwgaS5lLAo+IAo+ICAvKiBkb25lID0gMSBpZiB0aGVyZSBhcmUgbW9yZSBz dGF0cyB0byBnZXQgYW5kIGlmIGJ1bGtzdGF0ICovCj4gIC8qIHNob3VsZCBiZSBjYWxsZWQgYWdh aW4gKHVudXNlZCBoZXJlLCBidXQgdXNlZCBpbiBkbWFwaSkgKi8KPiAKPiBIb3dldmVyLCBJIGZh aWxlZCB0byBmaW5kIG91dCB3aHkgaXQgd291bGQgYmUgY2FsbGVkIGJ5IGdvaW5nIHRocm91Z2gK PiB0aGUgZG1hcGkgc291cmNlIGNvZGUuLi4KPiAKPiBJJ2xsIGtlZXAgdGhpcyBhcmd1bWVudCBp biBuZXh0IHJvdW5kIG9mIHBvc3QuCgpXZWxsLCBsZXQncyBjb25zaWRlciBob3cgRE1BUEkgdXNl cyBpdCBmaXJzdC4KCmRtYXBpX2lvY3RsKCkKICB1c2VfcnZwID0gMDsKICBjYXNlIERNX0dFVF9C VUxLQUxMOgogICAgdXNlX3J2cCA9IDE7CiAgICBkbV9nZXRfYnVsa2F0dHJfcnZwKCpydnApCiAg ICAgIGZzeXNfdmVjdG9yLT5nZXRfYnVsa2F0dHJfcnZwKHJ2cCkKICAgICAgICB4ZnNfZG1fZ2V0 X2J1bGthbGxfcnZwKCpydmFscCkKICAgICAgICAgIHhmc19idWxrc3RhdCgmZG9uZSkKICAgICAg ICAgICpydmFscCA9ICFkb25lID8gMSA6IDA7CgogIGlmICh1c2VfcnZwICYmICFlcnJvcikKICAg IHJldHVybiBydnA7CgoKT2ssIHNvIGl0IHJldHVybnMgdGhlICJkb25lIiBzdGF0dXMgdG8gdXNl cnNwYWNlLiBIb3cgaXMgImRvbmUiCmNhbGN1bGF0ZWQ/CgogICAgICAgIGlmIChhZ25vID49IG1w LT5tX3NiLnNiX2FnY291bnQpIHsKICAgICAgICAgICAgICAgIC8qCiAgICAgICAgICAgICAgICAg KiBJZiB3ZSByYW4gb3V0IG9mIGZpbGVzeXN0ZW0sIG1hcmsgbGFzdGlubyBhcyBvZmYKICAgICAg ICAgICAgICAgICAqIHRoZSBlbmQgb2YgdGhlIGZpbGVzeXN0ZW0sIHNvIHRoZSBuZXh0IGNhbGwK ICAgICAgICAgICAgICAgICAqIHdpbGwgcmV0dXJuIGltbWVkaWF0ZWx5LgogICAgICAgICAgICAg ICAgICovCiAgICAgICAgICAgICAgICAqbGFzdGlub3AgPSAoeGZzX2lub190KVhGU19BR0lOT19U T19JTk8obXAsIGFnbm8sIDApOwogICAgICAgICAgICAgICAgKmRvbmUgPSAxOwogICAgICAgIH0g ZWxzZQogICAgICAgICAgICAgICAgKmxhc3Rpbm9wID0gKHhmc19pbm9fdClsYXN0aW5vOwoKT2gs IHNvIGl0J3Mgbm90aGluZyBzcGVjaWFsIC0gdGhlIGxhc3Rpbm9wIGlzIHBvaW50ZWQgb3V0c2lk ZSB0aGUKY3VycmVudCBmaWxlc3lzdGVtIGJvdW5kcyBhbmQgZG9uZSBpcyBzZXQgdG8gMS4gSU9X cywgdGhlIGRtYXBpIGNvZGUKY291bGQgZWFzaWx5IGdlbmVyYXRlIHRoZSAiZG9uZSIgdmFsdWUg YmFzZWQgb24gdGhlIHJldHVybmVkCmxhc3Rpbm9wIHZhbHVlLiBpLmUuIHhmc19kbV9nZXRfYnVs a2FsbF9ydnAoKSBjYW4gZG8gdGhpcyBhZnRlciB0aGUKeGZzX2J1bGtzdGF0KCkgY2FsbDoKCglp ZiAoWEZTX0lOT19UT19BR05PKG1wLCBsYXN0aW5vcCkgPj0gbXAtPm1fc2Iuc2JfYWdjb3VudCkK CQkqcnZhbHAgPSAwOwoJZWxzZQoJCSpydmFscCA9IDE7CgpBbmQgdGhhdCBtZWFucyB3ZSBjYW4g cmVtb3ZlIHRoZSBkb25lIHBhcmFtZXRlciBmcm9tIHhmc19idWxrc3RhdCgpCmFuZCBubyBsb25n ZXIgaGF2ZSB0byBjYXJlIGFib3V0IHdoYXQgRE1BUEkgcmVxdWlyZXMuIEhlbmNlIEkgdGhpbmsK dGhlIHBhdGNoIGFzIGl0IHN0YW5kcyBkb2VzIG5vdCBpbXBhY3Qgb24gRE1BUEkgZnVuY3Rpb25h bGl0eSBhbmQgc28KaXQganVzdCBmaW5lIHRvIGNsZWFuIHVwLi4uCgpDaGVlcnMsCgpEYXZlLgot LSAKRGF2ZSBDaGlubmVyCmRhdmlkQGZyb21vcmJpdC5jb20KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCnhmcyBtYWlsaW5nIGxpc3QKeGZzQG9zcy5zZ2ku Y29tCmh0dHA6Ly9vc3Muc2dpLmNvbS9tYWlsbWFuL2xpc3RpbmZvL3hmcwo=