From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from arkanian.console-pimps.org ([212.110.184.194]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vyfdf-0000JN-Vz for kexec@lists.infradead.org; Thu, 02 Jan 2014 10:36:32 +0000 Date: Thu, 2 Jan 2014 10:35:49 +0000 From: Matt Fleming Subject: Re: [PATCH v7 00/12] kexec kernel efi runtime support Message-ID: <20140102103549.GC2618@console-pimps.org> References: <1387533742-18018-1-git-send-email-dyoung@redhat.com> <20131221173515.GE29501@console-pimps.org> <20140102024256.GB2563@darkstar.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140102024256.GB2563@darkstar.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Dave Young Cc: mjg59@srcf.ucam.org, msalter@redhat.com, linux-efi@vger.kernel.org, toshi.kani@hp.com, greg@kroah.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, leif.lindholm@linaro.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com, akpm@linux-foundation.org, mingo@kernel.org, vgoyal@redhat.com On Thu, 02 Jan, at 10:42:56AM, Dave Young wrote: > > Hi, Matt > > randconfig build robot reports several problems: > 1. sparse warnings which should be fixed by the early_memremap patches Yeah, this will be fixed up when Mark's memremap patch series gets merged. > Here is the fix for 2. and 3, please take a look. I'm not sure if I > should resend the patches or leave them to you. Please send these as separate patches and include the compiler errors in the commit message. I'll pick them up and send them to Peter. > build fix: move parse_efi_setup to efi*.c, call it in efi_init instead in setup.c Why have you moved the call site for parse_efi_setup()? What's the rationale? Parsing SETUP_* entries outside of parse_setup_data() seems to me to be a step backwards in terms of clarity. -- Matt Fleming, Intel Open Source Technology Center _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v7 00/12] kexec kernel efi runtime support Date: Thu, 2 Jan 2014 10:35:49 +0000 Message-ID: <20140102103549.GC2618@console-pimps.org> References: <1387533742-18018-1-git-send-email-dyoung@redhat.com> <20131221173515.GE29501@console-pimps.org> <20140102024256.GB2563@darkstar.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140102024256.GB2563-4/PLUo9XfK+sDdueE5tM26fLeoKvNuZc@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dave Young Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, toshi.kani-VXdhtT5mjnY@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org List-Id: linux-efi@vger.kernel.org On Thu, 02 Jan, at 10:42:56AM, Dave Young wrote: > > Hi, Matt > > randconfig build robot reports several problems: > 1. sparse warnings which should be fixed by the early_memremap patches Yeah, this will be fixed up when Mark's memremap patch series gets merged. > Here is the fix for 2. and 3, please take a look. I'm not sure if I > should resend the patches or leave them to you. Please send these as separate patches and include the compiler errors in the commit message. I'll pick them up and send them to Peter. > build fix: move parse_efi_setup to efi*.c, call it in efi_init instead in setup.c Why have you moved the call site for parse_efi_setup()? What's the rationale? Parsing SETUP_* entries outside of parse_setup_data() seems to me to be a step backwards in terms of clarity. -- Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750970AbaABKgN (ORCPT ); Thu, 2 Jan 2014 05:36:13 -0500 Received: from arkanian.console-pimps.org ([212.110.184.194]:54620 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbaABKgL (ORCPT ); Thu, 2 Jan 2014 05:36:11 -0500 Date: Thu, 2 Jan 2014 10:35:49 +0000 From: Matt Fleming To: Dave Young Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, bp@alien8.de, greg@kroah.com, toshi.kani@hp.com, akpm@linux-foundation.org, mingo@kernel.org, msalter@redhat.com, leif.lindholm@linaro.org Subject: Re: [PATCH v7 00/12] kexec kernel efi runtime support Message-ID: <20140102103549.GC2618@console-pimps.org> References: <1387533742-18018-1-git-send-email-dyoung@redhat.com> <20131221173515.GE29501@console-pimps.org> <20140102024256.GB2563@darkstar.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140102024256.GB2563@darkstar.nay.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 Jan, at 10:42:56AM, Dave Young wrote: > > Hi, Matt > > randconfig build robot reports several problems: > 1. sparse warnings which should be fixed by the early_memremap patches Yeah, this will be fixed up when Mark's memremap patch series gets merged. > Here is the fix for 2. and 3, please take a look. I'm not sure if I > should resend the patches or leave them to you. Please send these as separate patches and include the compiler errors in the commit message. I'll pick them up and send them to Peter. > build fix: move parse_efi_setup to efi*.c, call it in efi_init instead in setup.c Why have you moved the call site for parse_efi_setup()? What's the rationale? Parsing SETUP_* entries outside of parse_setup_data() seems to me to be a step backwards in terms of clarity. -- Matt Fleming, Intel Open Source Technology Center