From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH v2] staging: imx-drm: imx-tve: Fix a sparse warning Date: Thu, 2 Jan 2014 15:23:20 +0300 Message-ID: <20140102122320.GC28413@mwanda> References: <1387851464-6369-1-git-send-email-Ying.Liu@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by gabe.freedesktop.org (Postfix) with ESMTP id 20A5CFA894 for ; Thu, 2 Jan 2014 04:23:26 -0800 (PST) Content-Disposition: inline In-Reply-To: <1387851464-6369-1-git-send-email-Ying.Liu@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Liu Ying Cc: devel@driverdev.osuosl.org, fabio.estevam@freescale.com, gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, Dec 24, 2013 at 10:17:44AM +0800, Liu Ying wrote: > This patch declares the function of_get_tve_mode > as a static one to fix this sparse warning: > drivers/staging/imx-drm/imx-tve.c:563:11: warning: \ > symbol 'of_get_tve_mode' was not declared. \ > Should it be static? > > Acked-by: Shawn Guo > Signed-off-by: Liu Ying > --- > Changes from v2: > -Just added Shawn Guo's ack. No need to do that. regards, dan carpenter