From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Ivaylo Dimitrov <freemangordon@abv.bg>,
pavel@ucw.cz, pali.rohar@gmail.com
Subject: Re: [PATCH v2] Staging: tidspbridge: Use hashtable implementation
Date: Thu, 2 Jan 2014 18:00:42 +0300 [thread overview]
Message-ID: <20140102150042.GA30234@mwanda> (raw)
In-Reply-To: <1388159914-4132-1-git-send-email-ivo.g.dimitrov.75@gmail.com>
> + u32 val_size;
> + DECLARE_HASHTABLE(hash_table, GH_HASH_ORDER);
> + u32 (*hash)(void *);
> + bool (*match)(void *, void *);
> + void (*delete)(void *);
I forgot to say, put the parameter name in the declaration.
+ u32 (*hash)(void *key);
+ bool (*match)(void *key, void *result);
+ void (*delete)(void *key);
I have no idea if those names are correct.
regards,
dan carpenter
next prev parent reply other threads:[~2014-01-02 15:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-25 17:29 [PATCH] Staging: tidspbridge: Use hashtable implementation Ivaylo DImitrov
2013-12-27 9:45 ` Pavel Machek
2013-12-27 15:58 ` [PATCH v2] " Ivaylo Dimitrov
2014-01-02 15:00 ` Dan Carpenter [this message]
2014-01-02 13:46 ` [PATCH] " Dan Carpenter
[not found] ` <52C9AAB3.6050300@gmail.com>
2014-01-05 18:58 ` [PATCH v2] " Ivaylo Dimitrov
2014-01-05 19:47 ` Dan Carpenter
2014-01-05 23:14 ` Ivaylo Dimitrov
2014-01-05 23:17 ` [PATCH v3] " Ivaylo Dimitrov
2014-01-05 21:18 ` [PATCH] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140102150042.GA30234@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=freemangordon@abv.bg \
--cc=gregkh@linuxfoundation.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.