From: Andrew Jones <drjones@redhat.com>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH 9/9] arm: initial drop
Date: Thu, 2 Jan 2014 19:44:36 +0100 [thread overview]
Message-ID: <20140102184436.GN9725@hawk.usersys.redhat.com> (raw)
In-Reply-To: <20140102180950.GJ27806@cbox>
On Thu, Jan 02, 2014 at 10:09:50AM -0800, Christoffer Dall wrote:
> On Thu, Jan 02, 2014 at 05:40:24PM +0000, Peter Maydell wrote:
> > On 2 January 2014 16:54, Andrew Jones <drjones@redhat.com> wrote:
> > > On Sat, Dec 28, 2013 at 10:31:35PM -0800, Christoffer Dall wrote:
> > >> On Wed, Dec 04, 2013 at 05:42:57PM +0100, Andrew Jones wrote:
> > >> > + ands r3, r8, #CR_B @set BE, if necessary
> > >> > + ldrne r3, =cpu_is_be
> > >> > + movne r4, #1
> > >>
> > >> This is deprecated for ARMv7 according to the ARM ARM. What is the
> > >> intention here? Does qemu support running this test tool with the
> > >> system configured for big-endian? If so, I think this is a build option
> > >> for this binary or you need to come up with some other
> > >> architecture-compliant method of detecting the endian-state.
> > >
> > > Yes, qemu allows big-endian. I haven't tested it though, but suspect
> > > someday we will want big-endian guests tested as well. I'll fix the
> > > detection.
> >
> > QEMU does not support system mode big-endian. (Some of the
> > pieces are there for it but we have no board that needs it.)
> >
> > Also, you should read up in the ARM ARM about the differences
> > between old style BE32 and new BE8. (The quick summary is here:
> > http://translatedcode.wordpress.com/2012/04/)
> > What you're trying to do here is enable old-style BE32. This is
> > not supported on any ARMv7 or later CPU, which means it does
> > not overlap at all with virtualization support.
> >
> > We probably do care about BE8 big-endian guest support testing.
> > (kvmtool can run guests in this mode; QEMU doesn't currently).
> >
> Yeah, so I think this logic should go away from the test suite for now,
> focs on getting a decent set of actual functional tests up and running,
> and then probably add aarch64 support before looking at big-endian
> support.
>
OK, sounds good. The cpu_is_be stuff scattered about should still be fine
to leave in, and we can go about actually detecting BE and setting
cpu_is_be whenever.
thanks,
drew
next prev parent reply other threads:[~2014-01-02 18:44 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 16:42 [PATCH 0/9 v2] kvm-unit-tests/arm: initial drop Andrew Jones
2013-12-04 16:42 ` [PATCH 1/9] remove unused files Andrew Jones
2013-12-04 16:42 ` [PATCH 2/9] makefile and run_tests tweaks Andrew Jones
2013-12-29 6:30 ` Christoffer Dall
2014-01-02 14:30 ` Andrew Jones
2013-12-04 16:42 ` [PATCH 3/9] clean root dir of all x86-ness Andrew Jones
2013-12-29 6:30 ` Christoffer Dall
2014-01-02 15:00 ` Andrew Jones
2014-01-02 17:16 ` Christoffer Dall
2013-12-04 16:42 ` [PATCH 4/9] move x86's simple heap management to common code Andrew Jones
2013-12-29 6:30 ` Christoffer Dall
2014-01-02 15:17 ` Andrew Jones
2014-01-02 17:17 ` Christoffer Dall
2013-12-04 16:42 ` [PATCH 5/9] Introduce libio to common code for io read/write Andrew Jones
2013-12-29 6:30 ` Christoffer Dall
2014-01-02 15:47 ` Andrew Jones
2014-01-02 17:19 ` Christoffer Dall
2014-01-02 18:38 ` Andrew Jones
2013-12-04 16:42 ` [PATCH 6/9] Introduce a simple iomap structure Andrew Jones
2013-12-29 6:30 ` Christoffer Dall
2014-01-02 16:04 ` Andrew Jones
2014-01-02 17:23 ` Christoffer Dall
2014-01-02 18:40 ` Andrew Jones
2014-01-02 21:05 ` Christoffer Dall
2014-01-02 17:32 ` Peter Maydell
2013-12-04 16:42 ` [PATCH 7/9] Add halt() and some error codes Andrew Jones
2013-12-29 6:31 ` Christoffer Dall
2013-12-04 16:42 ` [PATCH 8/9] Introduce virtio-testdev Andrew Jones
2013-12-29 6:31 ` Christoffer Dall
2014-01-02 16:16 ` Andrew Jones
2014-01-02 17:27 ` Christoffer Dall
2014-01-02 18:41 ` Andrew Jones
2013-12-04 16:42 ` [PATCH 9/9] arm: initial drop Andrew Jones
2013-12-29 6:31 ` Christoffer Dall
2013-12-29 9:18 ` Peter Maydell
2014-01-02 16:54 ` Andrew Jones
2014-01-02 17:40 ` Peter Maydell
2014-01-02 18:09 ` Christoffer Dall
2014-01-02 18:44 ` Andrew Jones [this message]
2014-01-02 17:44 ` Christoffer Dall
2014-01-02 18:50 ` Andrew Jones
2014-01-02 19:17 ` Christoffer Dall
2014-01-03 17:52 ` Andrew Jones
2014-01-03 17:55 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140102184436.GN9725@hawk.usersys.redhat.com \
--to=drjones@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=peter.maydell@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.