From: Bjorn Helgaas <bhelgaas@google.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-pci@vger.kernel.org, 'Mohit Kumar' <mohit.kumar@st.com>
Subject: Re: [PATCH] PCI: designware: Fix indent code style
Date: Thu, 2 Jan 2014 14:48:36 -0700 [thread overview]
Message-ID: <20140102214836.GB7228@google.com> (raw)
In-Reply-To: <000401cf029a$d63943d0$82abcb70$%han@samsung.com>
On Fri, Dec 27, 2013 at 09:30:25AM +0900, Jingoo Han wrote:
> Fix indent code style and replace 'MSI interrupt controller'
> of comment with 'MSI controller', in order to fix the following
> checkpatch issues.
>
> ERROR: code indent should use tabs where possible
> WARNING: please, no spaces at the start of a line
> WARNING: line over 80 characters
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied to pci/host-designware for v3.14, thanks!
Bjorn
> ---
> drivers/pci/host/pcie-designware.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 4a08d30..17ce88f 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -213,14 +213,14 @@ static int find_valid_pos0(struct pcie_port *pp, int msgvec, int pos, int *pos0)
> }
>
> static void clear_irq_range(struct pcie_port *pp, unsigned int irq_base,
> - unsigned int nvec, unsigned int pos)
> + unsigned int nvec, unsigned int pos)
> {
> unsigned int i, res, bit, val;
>
> for (i = 0; i < nvec; i++) {
> irq_set_msi_desc_off(irq_base, i, NULL);
> clear_bit(pos + i, pp->msi_irq_in_use);
> - /* Disable corresponding interrupt on MSI interrupt controller */
> + /* Disable corresponding interrupt on MSI controller */
> res = ((pos + i) / 32) * 12;
> bit = (pos + i) % 32;
> dw_pcie_rd_own_conf(pp, PCIE_MSI_INTR0_ENABLE + res, 4, &val);
> --
> 1.7.10.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-01-02 21:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-27 0:30 [PATCH] PCI: designware: Fix indent code style Jingoo Han
2014-01-02 21:48 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140102214836.GB7228@google.com \
--to=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=linux-pci@vger.kernel.org \
--cc=mohit.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.