From: mmarek@suse.cz (Michal Marek)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH resend] scripts: Coccinelle script for pm_runtime_* return checks with IS_ERR_VALUE
Date: Fri, 3 Jan 2014 14:40:10 +0100 [thread overview]
Message-ID: <20140103134010.GA1676@sepie.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1401031429140.2095@hadrien>
On Fri, Jan 03, 2014 at 02:29:35PM +0100, Julia Lawall wrote:
>
> On Fri, 3 Jan 2014, Michal Marek wrote:
>
> > On 2013-12-02 14:39, Nishanth Menon wrote:
> > > As indicated by Sekhar in [1], there seems to be a tendency to use
> > > IS_ERR_VALUE to check the error result for pm_runtime_* functions which
> > > make no sense considering commit c48cd65 (ARM: OMAP: use consistent
> > > error checking) - the error values can either be < 0 for error OR
> > > 0, 1 in cases where we have success.
> > >
> > > So, setup a coccinelle script to help identify the same.
> >
> > Julia, Gilles, do you have any objections to this semantic patch?
>
> No objections.
>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Thanks, applied to kbuild.git#misc.
Michal
WARNING: multiple messages have this Message-ID (diff)
From: Michal Marek <mmarek@suse.cz>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Nishanth Menon <nm@ti.com>,
Gilles.Muller@lip6.fr, nicolas.palix@imag.fr,
linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr,
linux-pm@vger.kernel.org, Sekhar Nori <nsekhar@ti.com>,
Russell King <rmk+kernel@arm.linux.org.uk>
Subject: Re: [PATCH resend] scripts: Coccinelle script for pm_runtime_* return checks with IS_ERR_VALUE
Date: Fri, 3 Jan 2014 14:40:10 +0100 [thread overview]
Message-ID: <20140103134010.GA1676@sepie.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1401031429140.2095@hadrien>
On Fri, Jan 03, 2014 at 02:29:35PM +0100, Julia Lawall wrote:
>
> On Fri, 3 Jan 2014, Michal Marek wrote:
>
> > On 2013-12-02 14:39, Nishanth Menon wrote:
> > > As indicated by Sekhar in [1], there seems to be a tendency to use
> > > IS_ERR_VALUE to check the error result for pm_runtime_* functions which
> > > make no sense considering commit c48cd65 (ARM: OMAP: use consistent
> > > error checking) - the error values can either be < 0 for error OR
> > > 0, 1 in cases where we have success.
> > >
> > > So, setup a coccinelle script to help identify the same.
> >
> > Julia, Gilles, do you have any objections to this semantic patch?
>
> No objections.
>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Thanks, applied to kbuild.git#misc.
Michal
next prev parent reply other threads:[~2014-01-03 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 13:39 [Cocci] [PATCH resend] scripts: Coccinelle script for pm_runtime_* return checks with IS_ERR_VALUE Nishanth Menon
2013-12-02 13:39 ` Nishanth Menon
2013-12-02 13:39 ` Nishanth Menon
2014-01-03 12:57 ` [Cocci] " Michal Marek
2014-01-03 12:57 ` Michal Marek
2014-01-03 13:29 ` [Cocci] " Julia Lawall
2014-01-03 13:29 ` Julia Lawall
2014-01-03 13:40 ` Michal Marek [this message]
2014-01-03 13:40 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140103134010.GA1676@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.