From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Date: Fri, 03 Jan 2014 20:34:22 +0000 Subject: Re: [PATCH v2] allow xenfb initialization for hvm guests Message-Id: <20140103203422.GA2668@phenom.dumpdata.com> List-Id: References: <1388775730-2984-1-git-send-email-stefano.stabellini@eu.citrix.com> In-Reply-To: <1388775730-2984-1-git-send-email-stefano.stabellini@eu.citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Stefano Stabellini Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, linux-fbdev@vger.kernel.org On Fri, Jan 03, 2014 at 07:02:09PM +0000, Stefano Stabellini wrote: The title needs 'xen/fb' prefixed but that is easy enough. > There is no reasons why an HVM guest shouldn't be allowed to use xenfb. > As a matter of fact ARM guests, HVM from Linux POV, can use xenfb. > Given that no Xen toolstacks configure a xenfb backend for x86 HVM > guests, they are not affected. > > Please note that at this time QEMU needs few outstanding fixes to > provide xenfb on ARM: > > http://marc.info/?l=qemu-devel&m8739419700837&w=2 Cool. Is the video maintainer OK with the Xen maintainers stashing it in the Xen tree for Linus? Thanks! > > Signed-off-by: Stefano Stabellini > Acked-by: David Vrabel > CC: boris.ostrovsky@oracle.com > CC: plagnioj@jcrosoft.com > CC: tomi.valkeinen@ti.com > CC: linux-fbdev@vger.kernel.org > CC: konrad.wilk@oracle.com > --- > drivers/video/xen-fbfront.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront.c > index cd005c2..02e1c01 100644 > --- a/drivers/video/xen-fbfront.c > +++ b/drivers/video/xen-fbfront.c > @@ -692,7 +692,7 @@ static DEFINE_XENBUS_DRIVER(xenfb, , > > static int __init xenfb_init(void) > { > - if (!xen_pv_domain()) > + if (!xen_domain()) > return -ENODEV; > > /* Nothing to do if running in dom0. */ > -- > 1.7.10.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754674AbaACUgo (ORCPT ); Fri, 3 Jan 2014 15:36:44 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:23900 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754589AbaACUfe (ORCPT ); Fri, 3 Jan 2014 15:35:34 -0500 Date: Fri, 3 Jan 2014 15:34:22 -0500 From: Konrad Rzeszutek Wilk To: Stefano Stabellini Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v2] allow xenfb initialization for hvm guests Message-ID: <20140103203422.GA2668@phenom.dumpdata.com> References: <1388775730-2984-1-git-send-email-stefano.stabellini@eu.citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1388775730-2984-1-git-send-email-stefano.stabellini@eu.citrix.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 03, 2014 at 07:02:09PM +0000, Stefano Stabellini wrote: The title needs 'xen/fb' prefixed but that is easy enough. > There is no reasons why an HVM guest shouldn't be allowed to use xenfb. > As a matter of fact ARM guests, HVM from Linux POV, can use xenfb. > Given that no Xen toolstacks configure a xenfb backend for x86 HVM > guests, they are not affected. > > Please note that at this time QEMU needs few outstanding fixes to > provide xenfb on ARM: > > http://marc.info/?l=qemu-devel&m=138739419700837&w=2 Cool. Is the video maintainer OK with the Xen maintainers stashing it in the Xen tree for Linus? Thanks! > > Signed-off-by: Stefano Stabellini > Acked-by: David Vrabel > CC: boris.ostrovsky@oracle.com > CC: plagnioj@jcrosoft.com > CC: tomi.valkeinen@ti.com > CC: linux-fbdev@vger.kernel.org > CC: konrad.wilk@oracle.com > --- > drivers/video/xen-fbfront.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront.c > index cd005c2..02e1c01 100644 > --- a/drivers/video/xen-fbfront.c > +++ b/drivers/video/xen-fbfront.c > @@ -692,7 +692,7 @@ static DEFINE_XENBUS_DRIVER(xenfb, , > > static int __init xenfb_init(void) > { > - if (!xen_pv_domain()) > + if (!xen_domain()) > return -ENODEV; > > /* Nothing to do if running in dom0. */ > -- > 1.7.10.4 >