From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: fix type in parsing in nf_tables_set_alloc_name
Date: Sat, 4 Jan 2014 00:02:47 +0100 [thread overview]
Message-ID: <20140103230247.GA6283@localhost> (raw)
In-Reply-To: <1388490005-6771-1-git-send-email-dborkman@redhat.com>
On Tue, Dec 31, 2013 at 12:40:05PM +0100, Daniel Borkmann wrote:
> In nf_tables_set_alloc_name(), we are trying to find a new, unused
> name for our new set and interate through the list of present sets.
> As far as I can see, we're using format string %d to parse already
> present names in order to mark their presence in a bitmap, so that
> we can later on find the first 0 in that map to assign the new set
> name to. We should rather use a temporary variable of type int to
> store the result of sscanf() to, and for making sanity checks on.
Applied, thanks.
prev parent reply other threads:[~2014-01-03 23:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-31 11:40 [PATCH nf-next] netfilter: fix type in parsing in nf_tables_set_alloc_name Daniel Borkmann
2014-01-03 23:02 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140103230247.GA6283@localhost \
--to=pablo@netfilter.org \
--cc=dborkman@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.