All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Voigt <hvoigt@hvoigt.net>
To: Lorenzo Keller <lkeller@marvell.com>
Cc: git@vger.kernel.org
Subject: Re: git fetch doesn't ignore funny refs
Date: Sun, 5 Jan 2014 02:22:51 +0100	[thread overview]
Message-ID: <20140105012251.GA12969@book-mint> (raw)
In-Reply-To: <52B04515.8020609@marvell.com>

On Tue, Dec 17, 2013 at 01:35:33PM +0100, Lorenzo Keller wrote:
> A check as this one:
> 
> if (check_refname_format(ref->name, 0))
>    continue;
> 
> fixes the problem for me.
> 
> I report here bug and fix in the hope it can be reviewed and integrated
> in future git releases.

Since it seems you already have a fix: How about sending a proper patch
(possibly you want to extend this with a warning message) so people can
discuss and integrate your fix here? See Documentation/SubmittingPatches
for further information.

Cheers Heiko

      reply	other threads:[~2014-01-05  1:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17 12:35 git fetch doesn't ignore funny refs Lorenzo Keller
2014-01-05  1:22 ` Heiko Voigt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140105012251.GA12969@book-mint \
    --to=hvoigt@hvoigt.net \
    --cc=git@vger.kernel.org \
    --cc=lkeller@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.