From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [dm-devel] [PATCH] kobject: provide kobject_put_wait to fix module unload race Date: Sun, 5 Jan 2014 10:26:40 -0800 Message-ID: <20140105182640.GA2522@kroah.com> References: <52C98BCC.9040900@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <52C98BCC.9040900@acm.org> Sender: linux-kernel-owner@vger.kernel.org To: Bart Van Assche Cc: Mikulas Patocka , Jeff Mahoney , torvalds@linux-foundation.org, device-mapper development , paulmck@linux.vnet.ibm.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org List-Id: dm-devel.ids On Sun, Jan 05, 2014 at 05:43:56PM +0100, Bart Van Assche wrote: > On 01/04/14 19:06, Mikulas Patocka wrote: > > - if (t && !t->release) > > - pr_debug("kobject: '%s' (%p): does not have a release() " > > - "function, it is broken and must be fixed.\n", > > - kobject_name(kobj), kobj); > > - > > Has it been considered to issue a warning if no release function has > been defined and free_completion == NULL instead of removing the above > debug message entirely ? I think even with this patch applied it is > still wrong to invoke kobject_put() on an object without defining a > release function. This patch isn't going to be applied, and I've reverted the original commit, so there shouldn't be any issues anymore with this code. thanks, greg k-h