From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 1/3] netfilter: nf_tables: fix suboptimal set selection Date: Sun, 5 Jan 2014 21:28:35 +0000 Message-ID: <20140105212406.GA13624@macbook.localnet> References: <1388956728-6754-1-git-send-email-pablo@netfilter.org> <1388956728-6754-2-git-send-email-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: Pablo Neira Ayuso Return-path: Received: from stinky.trash.net ([213.144.137.162]:47482 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbaAEV2j (ORCPT ); Sun, 5 Jan 2014 16:28:39 -0500 Content-Disposition: attachment In-Reply-To: <1388956728-6754-2-git-send-email-pablo@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Sun, Jan 05, 2014 at 10:18:46PM +0100, Pablo Neira Ayuso wrote: > The rb-tree is currently used for simple sets and maps with no > intervals which is suboptimal. Fix it by adding the weight field > to each existing set implementation, this value allows to select > the best candidate in case that several set types can be used. Ohh, lets do this properly. This is one point why I was opposed to a merge at this stage, lets not paper over this but fix this how it was intended. I'll work on that after finishing the inet family. Until then no harm is done, just some memory waste.