From: Lee Jones <lee.jones@linaro.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: [PATCH 1/2] mfd: twl6040: Staticize local variable
Date: Mon, 6 Jan 2014 09:30:33 +0000 [thread overview]
Message-ID: <20140106093033.GC23772@lee--X1> (raw)
In-Reply-To: <1387605142-4743-1-git-send-email-sachin.kamat@linaro.org>
On Sat, 21 Dec 2013, Sachin Kamat wrote:
> 'twl6040_patch' is local to this file.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/mfd/twl6040.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c
> index 51b6df1a7949..75316fb33448 100644
> --- a/drivers/mfd/twl6040.c
> +++ b/drivers/mfd/twl6040.c
> @@ -86,7 +86,7 @@ static struct reg_default twl6040_defaults[] = {
> { 0x2E, 0x00 }, /* REG_STATUS (ro) */
> };
>
> -struct reg_default twl6040_patch[] = {
> +static struct reg_default twl6040_patch[] = {
> /* Select I2C bus access to dual access registers */
> { TWL6040_REG_ACCCTL, 0x09 },
> };
This has already been fixed.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-01-06 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-21 5:52 [PATCH 1/2] mfd: twl6040: Staticize local variable Sachin Kamat
2013-12-21 5:52 ` [PATCH 2/2] mfd: rtl8411: Staticize local symbol Sachin Kamat
2014-01-06 9:30 ` Lee Jones
2014-01-06 9:30 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106093033.GC23772@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=sachin.kamat@linaro.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.