Re: [meta-qt5][PATCH] qtwebkit: Depend on gstreamer-1.0 instead of 0.10

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2717 bytes --]

On Mon, Jan 06, 2014 at 11:22:27AM +0100, Nicolas Dechesne wrote:
> On Tue, Dec 31, 2013 at 12:37 PM, Martin Jansa <martin.jansa@gmail.com>wrote:
> 
> > * since this commit:
> >   commit e0debe138cb59c140ebbc69755d36028d2b89459
> >   Author: Allan Sandfeld Jensen <allan.jensen@digia.com>
> >   Date:   Thu Feb 28 13:42:27 2013 +0100
> >   Subject: Switch QtWebKit to GStreamer 1.0.
> >
> >   qtwebkit supports 1.0 and will use that by default when found
> >
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  recipes-qt/qt5/qtwebkit.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/recipes-qt/qt5/qtwebkit.inc b/recipes-qt/qt5/qtwebkit.inc
> > index c0e0648..9b334ae 100644
> > --- a/recipes-qt/qt5/qtwebkit.inc
> > +++ b/recipes-qt/qt5/qtwebkit.inc
> > @@ -5,7 +5,7 @@ LIC_FILES_CHKSUM =
> > "file://Source/WebCore/rendering/RenderApplet.h;endline=22;md
> >
> >  file://Source/WebKit/gtk/webkit/webkit.h;endline=21;md5=b4fbe9f4a944f1d071dba1d2c76b3351
> > \
> >
> >  file://Source/JavaScriptCore/parser/Parser.h;endline=23;md5=b57c8a2952a8d0e655988fa0ecb2bf7f"
> >
> > -DEPENDS += "qtdeclarative qtlocation qtsensors ${ICU} ruby-native sqlite3
> > glib-2.0 gstreamer gst-plugins-base libxslt"
> > +DEPENDS += "qtdeclarative qtlocation qtsensors ${ICU} ruby-native sqlite3
> > glib-2.0 gstreamer-1.0 gst-plugins-base-1.0 libxslt"
> >
> >  # qtwebkit gets terribly big when linking with all debug info, disable by
> > default
> >  QTWEBKIT_DEBUG = "QMAKE_CFLAGS+=-g0 QMAKE_CXXFLAGS+=-g0"
> >
> 
> hmm. that's a bit rough... GST1.0 for ARM SoC is (sadly) still not the
> norm.. I haven't checked upstream, but does it still support 0.10 or 1.0 or
> only 1.0? If both are supported could (should?) we use PACKAGECONFIG to
> offer both in our recipe?

PACKAGECONFIG is possible and even easier with this upstream change
(before it was always checking for 0.10 first and you would need to
patch .pri file first to make the dependency deterministic).

> right now i am using the dora branch and qt5.1.1 which hasn't been updated
> for a while, which is fine.

This is only for master which will soon became just qt5.2.0 where
gstreamer-1.0 is used by default and I believe more tested than
integration with gstreamer-0.10.

So it won't change anything for people using 5.1.1 from dora branch. If
someone really wants to use gst-0.10 with 5.2.0 I would accept patch for
PACKAGECONFIG.

gst-1.0* seems to be working fine for our ARM project and
we've removed all gst-0.10 from our images lately - that's why I've
noticed this qtwebkit dependency.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]