All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nf_conntrack: fix skb_header_pointer API usages in DCCP
Date: Mon, 6 Jan 2014 14:14:32 +0100	[thread overview]
Message-ID: <20140106131432.GA8362@localhost> (raw)
In-Reply-To: <1388966274-9532-1-git-send-email-dborkman@redhat.com>

On Mon, Jan 06, 2014 at 12:57:54AM +0100, Daniel Borkmann wrote:
> Some occurences in the netfilter tree use skb_header_pointer() in
> the following way ...
> 
>   struct dccp_hdr _dh, *dh;
>   ...
>   skb_header_pointer(skb, dataoff, sizeof(_dh), &dh);

I see, we're not crashing because *dh is 4 bytes at worst case, which
matches with the size of the dccp_hdr header.

Applied, thanks.

      reply	other threads:[~2014-01-06 13:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-05 23:57 [PATCH nf] netfilter: nf_conntrack: fix skb_header_pointer API usages in DCCP Daniel Borkmann
2014-01-06 13:14 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140106131432.GA8362@localhost \
    --to=pablo@netfilter.org \
    --cc=dborkman@redhat.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.