From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45460)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.galvani@gmail.com>) id 1W0Afw-00029E-TV
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 08:57:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <b.galvani@gmail.com>) id 1W0Afo-0004Ew-0F
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 08:57:04 -0500
Received: from mail-ea0-x231.google.com ([2a00:1450:4013:c01::231]:45817)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.galvani@gmail.com>) id 1W0Afn-0004Ek-Q9
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 08:56:55 -0500
Received: by mail-ea0-f177.google.com with SMTP id n15so7922166ead.8
	for <qemu-devel@nongnu.org>; Mon, 06 Jan 2014 05:56:54 -0800 (PST)
Date: Mon, 6 Jan 2014 14:56:44 +0100
From: Beniamino Galvani <b.galvani@gmail.com>
Message-ID: <20140106135643.GA4400@gmail.com>
References: <1388654332-10303-1-git-send-email-b.galvani@gmail.com>
	<1388654332-10303-3-git-send-email-b.galvani@gmail.com>
	<52C9FD8E.5040200@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52C9FD8E.5040200@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Li Guang <lig.fnst@cn.fujitsu.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

On Mon, Jan 06, 2014 at 08:49:18AM +0800, Li Guang wrote:
> Hi,
> please use prefix AwA10 for names instead of Aw,
> also PATCH 1/2.

Hi,

I agree with you that there is an inconsistency in the naming of EMAC
and other A10 devices (timer, interrupt controller).

But the EMAC core is used not only on the A10; since it can be found
on other SoC of the Allwinner family, shouldn't the name be generic so
that it can be reused more easily in the future by other SoC
implementations?

Regards,
Beniamino