Re: [PATCH V4] xl: create VFB for PV guest when VNC is specified

[Wei Liu <wei.liu2@citrix.com>]

On Mon, Jan 06, 2014 at 05:29:01PM +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH V4] xl: create VFB for PV guest when VNC is specified"):
> > And now George has gone away and left me holding the can, smart move on
> > his part ;-)
> 
> I have also reviewed this patch again.
> 
> Firstly,
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> Now, onto the RM questions.
> 
> > The potential risk is that this breaks the existing vfb syntax which
> > works, or it breaks the hvm stuff. This is of particular concern because
> > I don't think any of that is covered by osstest (except perhaps hvm
> > console, but that might only be on some other error when osstest takes a
> > screenshot), so the probability of finding it before release is reliant
> > on manual testing/test days/user testing etc.
> > Are you happy that all the existing options keep working?
> 
> Wei, could you tell us what configuration(s) you tested ?
> 

#1 PV guest (to see if it causes regression):
vfb = ['vnc=1,vncunused=1,vnclisten=0.0.0.0']

#2 PV guest (to see if it fixes the bug):
vnc=1
vncunused=1
vnclisten='0.0.0.0'

#3 PV guest (to test if if will create more than 1 VFB):
vfb = ['vnc=1,vncunused=1,vnclisten=0.0.0.0']
vnc=1
vncunused=1
vnclisten='0.0.0.0'

#4 HVM guest (to see if it causes regression):
vnc=1
vncunused=1
vnclisten='0.0.0.0'

#5 HVM guest (to see if xl errneously parse vfb= for HVM):
vfb = ['vnc=1,vncunused=1,vnclisten=0.0.0.0']

Wei.