From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: Andrey Vagin <avagin@openvz.org>,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, vvs@openvz.org,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] netfilter: nf_conntrack: release conntrack from rcu callback
Date: Tue, 7 Jan 2014 01:44:38 +0400 [thread overview]
Message-ID: <20140106214438.GC2360@moon> (raw)
In-Reply-To: <20140106212326.GB9894@breakpoint.cc>
On Mon, Jan 06, 2014 at 10:23:26PM +0100, Florian Westphal wrote:
> >
> > No? Or there something obvious I'm missing?
>
> IMHO this isn't obvious at all :-)
>
> But, in the example above, the atomic_inc_not_zero() should fail
> until after __nf_conntrack_alloc() re-inits the refcount to 1.
>
> The mb there should make sure ____nf_conntrack_find() doesn't
> find an outdated tuple before this.
Yeah, thanks!
next prev parent reply other threads:[~2014-01-06 21:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 15:54 [PATCH] netfilter: nf_conntrack: release conntrack from rcu callback Andrey Vagin
2014-01-06 17:02 ` Florian Westphal
2014-01-06 17:21 ` Cyrill Gorcunov
2014-01-06 18:09 ` Cyrill Gorcunov
2014-01-06 21:23 ` Florian Westphal
2014-01-06 21:44 ` Cyrill Gorcunov [this message]
2014-01-06 20:54 ` Andrew Vagin
2014-01-06 21:53 ` Florian Westphal
2014-01-07 10:39 ` Andrey Wagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106214438.GC2360@moon \
--to=gorcunov@gmail.com \
--cc=avagin@openvz.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=vvs@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.