From: Huang Shijie <b32955@freescale.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org, Pekon Gupta <pekon@ti.com>
Subject: Re: [PATCH v3 5/5] mtd: nand: use __packed shorthand
Date: Tue, 7 Jan 2014 13:52:44 +0800 [thread overview]
Message-ID: <20140107055243.GC8109@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <1388795828-24808-5-git-send-email-computersforpeace@gmail.com>
On Fri, Jan 03, 2014 at 04:37:08PM -0800, Brian Norris wrote:
> To be consistent with the rest of include/linux/mtd/nand.h, we should
> use the __packed shorthand instead of __attribute__((packed)).
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> ---
> No change since v1
>
> include/linux/mtd/nand.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> index e3621aba1417..2413bac095ae 100644
> --- a/include/linux/mtd/nand.h
> +++ b/include/linux/mtd/nand.h
> @@ -292,7 +292,7 @@ struct nand_onfi_params {
> u8 vendor[88];
>
> __le16 crc;
> -} __attribute__((packed));
> +} __packed;
>
> #define ONFI_CRC_BASE 0x4F4E
>
> --
> 1.8.3.2
>
>
>
Acked-by: Huang Shijie <b32955@freescale.com>
next prev parent reply other threads:[~2014-01-07 6:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-04 0:37 [PATCH v3 1/5] mtd: nand: localize ECC failures per page Brian Norris
2014-01-04 0:37 ` [PATCH v3 2/5] mtd: nand: add ONFI vendor block for Micron Brian Norris
2014-01-07 5:52 ` Huang Shijie
2014-01-04 0:37 ` [PATCH v3 3/5] mtd: nand: add generic READ RETRY support Brian Norris
2014-01-07 6:17 ` Huang Shijie
2014-01-13 8:04 ` Brian Norris
2014-01-13 7:36 ` Huang Shijie
2014-01-07 8:21 ` Huang Shijie
2014-01-04 0:37 ` [PATCH v3 4/5] mtd: nand: support Micron READ RETRY Brian Norris
2014-01-04 12:49 ` Huang Shijie
2014-01-07 6:54 ` Huang Shijie
2014-01-04 0:37 ` [PATCH v3 5/5] mtd: nand: use __packed shorthand Brian Norris
2014-01-07 5:52 ` Huang Shijie [this message]
2014-01-07 7:02 ` [PATCH v3 1/5] mtd: nand: localize ECC failures per page Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107055243.GC8109@shlinux2.ap.freescale.net \
--to=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=pekon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.