From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Triplett Subject: Re: [PATCH 82/85] drivers: gpu: Mark functions as static in vmwgfx_kms.c Date: Tue, 7 Jan 2014 02:51:54 -0800 Message-ID: <20140107105154.GC4891@leaf> References: <477dcfde0b9247c91030dedcbf71af7dafdb7bf4.1389018325.git.rashika.kheria@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jakob Bornecrantz Cc: Rashika Kheria , Linux Kernel Mailing List , Daniel Vetter , DRI Development , Dave Airlie , Rob Clark List-Id: dri-devel@lists.freedesktop.org On Tue, Jan 07, 2014 at 11:21:12AM +0100, Jakob Bornecrantz wrote: > On Mon, Jan 6, 2014 at 5:48 PM, Rashika Kheria wrote: > > Mark functions as static because they are not used outside the file > > drm/vmwgfx/vmwgfx_kms.c. > > > > This eliminates the following warnings in drm/vmwgfx/vmwgfx_kms.c: > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:43:6: warning: no previous prot= otype for =E2=80=98vmw_clip_cliprects=E2=80=99 [-Wmissing-prototypes] > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:426:6: warning: no previous pro= totype for =E2=80=98vmw_framebuffer_surface_destroy=E2=80=99 [-Wmissing= -prototypes] > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:592:5: warning: no previous pro= totype for =E2=80=98vmw_framebuffer_surface_dirty=E2=80=99 [-Wmissing-p= rototypes] > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:757:6: warning: no previous pro= totype for =E2=80=98vmw_framebuffer_dmabuf_destroy=E2=80=99 [-Wmissing-= prototypes] > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:943:5: warning: no previous pro= totype for =E2=80=98vmw_framebuffer_dmabuf_dirty=E2=80=99 [-Wmissing-pr= ototypes] > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1666:5: warning: no previous pr= ototype for =E2=80=98vmw_du_update_layout=E2=80=99 [-Wmissing-prototype= s] > > > > Signed-off-by: Rashika Kheria > > Reviewed-by: Josh Triplett > > --- > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 >=20 > This and patch 83, 84, 85 are > Reviewed-by: Jakob Bornecrantz Can you take them through your tree, or are you expecting them to follo= w another path? - Josh Triplett