From: Mark Brown <broonie@kernel.org>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 5/5] ASoC: mc13783: Add devicetree support
Date: Tue, 7 Jan 2014 11:08:12 +0000 [thread overview]
Message-ID: <20140107110812.GU31886@sirena.org.uk> (raw)
In-Reply-To: <20140107110053.1e353a58ac661c7c64860fe3@mail.ru>
[-- Attachment #1.1: Type: text/plain, Size: 818 bytes --]
On Tue, Jan 07, 2014 at 11:00:53AM +0400, Alexander Shiyan wrote:
> So, we need codec phandle.
> The codec is probed by MC13XXX MFD core, and codec pdev not contain
> compatible string, but we should associate our codec with DT.
> if ASoC core wants to use codec it will try to find it by of_node.
> Maybe my opinion is wrong, fixme.
The fact that we happen to use platform devices inside Linux to split
the MFD between subsystems isn't something that should leak out into the
device tree representation, this is a Linux implementation detail. The
card should be referencing the root node for the device in its binding.
You're also confusing the idea of using an of_node for something with
putting it into the struct device; you should never need to modify
what's in the struct device to use the device tree data.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-01-07 11:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 7:38 [PATCH 1/5] ASoC: mc13783: Use module_platform_driver_probe() Alexander Shiyan
2014-01-05 7:38 ` [PATCH 2/5] ASoC: mc13783: Use core error messages if registration fails Alexander Shiyan
2014-01-06 15:38 ` Mark Brown
2014-01-05 7:38 ` [PATCH 3/5] ASoC: mc13783: Drop fixed ADC & DAC ports usage Alexander Shiyan
2014-01-06 15:38 ` Mark Brown
2014-01-05 7:38 ` [PATCH 4/5] ASoC: mc13783: trivial: Cleanup module Alexander Shiyan
2014-01-06 15:38 ` Mark Brown
2014-01-05 7:38 ` [PATCH 5/5] ASoC: mc13783: Add devicetree support Alexander Shiyan
2014-01-06 13:28 ` Mark Brown
2014-01-06 13:46 ` Alexander Shiyan
2014-01-06 15:12 ` Mark Brown
2014-01-07 7:00 ` Alexander Shiyan
2014-01-07 11:08 ` Mark Brown [this message]
2014-01-06 15:38 ` [PATCH 1/5] ASoC: mc13783: Use module_platform_driver_probe() Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107110812.GU31886@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=shc_work@mail.ru \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.